Repository navigation
Remove same-module test-fn calls from v2 witnesses, with roster rows - #11495
Closed
gunbai-bot[bot] wants to merge 1 commit into
Closed
gunbai-bot[bot] wants to merge 1 commit into
gunbai-bot[bot] wants to merge 1 commit into
Conversation
No code may call or reference a test fn. Per site: - single-callee keystones (compile_eval isolate_t1..t3, ts_g2_sg5, door quad_with_peer x2, field_access/record_construct *_keystone x6) are deleted; the callee is enrolled on its own. Grandfathered-roster identities get typed WitnessDeleted removals (the cut is frozen); witness_row_cost_basis and witness_deferral_freeze rows are removed. - parse_table_memo: the order-independence test fn and its three plain wrappers only re-ran the insert/lookup door test fns in two orders of a pure conjunction; deleted, and its commit_workflow check_fns row with it. - conjunct drops where a test fn or plain helper re-called an enrolled test fn (complexity budget gate, discrimination_family_gate, sg_rc, p9 registry owner). - data rows referencing a test fn: bounded_summation's claim reads the two plain helpers directly; binds_to_resolved_claim_passes (unconsumed) is deleted. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove same-module test-fn calls from v2 witnesses, with roster rows
No code may call or reference a test fn. Per site:
door quad_with_peer x2, field_access/record_construct *_keystone x6)
are deleted; the callee is enrolled on its own. Grandfathered-roster
identities get typed WitnessDeleted removals (the cut is frozen);
witness_row_cost_basis and witness_deferral_freeze rows are removed.
wrappers only re-ran the insert/lookup door test fns in two orders of a
pure conjunction; deleted, and its commit_workflow check_fns row with it.
test fn (complexity budget gate, discrimination_family_gate, sg_rc,
p9 registry owner).
two plain helpers directly; binds_to_resolved_claim_passes (unconsumed)
is deleted.
Part of the owner ruling that no code may call or reference a
test fn(sibling PRs #11488 #11489 #11490). Text-scan audit, verified per site by reading; nosrc/v1changes.🤖 Generated with Claude Code