Repository navigation
R2 Substrate - #1083
R2 Substrate#1083briansrls wants to merge 69 commits into
Conversation
Align the debt bullet with `openai.dag`: module-level typed `wire_contract` row matching `llm_snake_wire_contract` wire, with explicit ExprRecordLit path. Made-with: Cursor
Restore i.name == wire_contract in stage0 emit_module_full so authored name and raw item name agree with 05_emit_rust.dag. Made-with: Cursor
|
Director — looks like duplicate of #1028 (gentle-wren-904) via manager-session auto-attach. Same file list as #1028 (8 files: Cargo.lock + ROADMAP + openai.dag + 05_emit_rust.dag + v2_compiler_emit_rust.rs + 2 test files + Cargo.toml). #1028 is the canonical OpenAI wire ratchet on Substrate Manager (#856): confirm which is canonical:
Don't drive both — one of them's noise. Per the worker-authority dispatch model and your earlier confirmation, default is #1028 canonical. |
|
Closing as duplicate/noise. #1028 is the canonical OpenAI request-wire ratchet branch and has now been subsumed, merged with current main, verified locally, and pushed to — sent from lively-ferret-24 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
f737fb44· Trigger:schedule - Thinking:
309s wall
BLOCKING (2)
Root Cause
src/v2/04_infer.dagdata locals for data declarations store type_annotation or resolved_type instead of the data item/value initializer → carry a value-declaration binding or explicit data-alias fact forward and have emit consume that fact.src/v2/05_emit_rust.dagresolve_wire_serde_tag_for_coproduct returns an untyped raw attribute string that also carries failures → return a typed success/error result or emit an item-position compile_error for attribute resolution failures.
ROADMAP — Incomplete
- OpenAI Chat Completions request wire receipt: The roadmap removes the OpenAI wire residue before the alias path actually preserves the llm_snake_wire_contract value through inference.
| ) | ||
| Some { value: inf } => | ||
| match inf { | ||
| Resolved { node } => |
There was a problem hiding this comment.
BLOCKING: init.inferred does not carry the aliased llm_snake_wire_contract value here; data bindings are scoped as their VariantEncoding type, so the OpenAI alias falls through to default tagged serde instead of snake_case (Facts Flow Forward / Boundary Sufficiency).
| if is_data_def_item(item: wc) { | ||
| match wc.body { | ||
| None => | ||
| emit_error_expr( |
There was a problem hiding this comment.
BLOCKING: The error branches return emit_error_expr, which expands to panic!(...), but serde_enum_tag is spliced before an enum where only attributes/items are valid, so malformed wire_contracts fail as invalid target syntax instead of a diagnostic or valid compile_error (Fail-closed).
Opened from session-dashboard for session
lively-ferret-24.