Repository navigation
FLOOR REPAIR: in-flight shared fill is charged as marginal until store — repair the classification boundary (design first, characterization is landed in docs/plans/required-floor-in-flight-shared-fill-findings.md) - #10018
gunbai-bot[bot] wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Duplicate of #10003, which was squash-merged as fb481ae. The dashboard re-adopted Closing rather than re-running review and CI on work that has already landed. The 3 failing checks here are the srv1 runner $HOME/euid rustup fault, which the operator is handling separately. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecd2c0e858
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| E::ShellOutputLimitExceeded { .. } => WitnessRuntimeCause::ShellOutputLimitExceeded, | ||
| E::CallContractMismatch { .. } => WitnessRuntimeCause::CallContractMismatch, | ||
| E::FillBudgetExceeded { .. } => WitnessRuntimeCause::FillBudgetExceeded, |
There was a problem hiding this comment.
When an admitted fill crosses the CPU ceiling, map_budget_error_to_witness_refusal leaves FillBudgetExceeded unchanged, so run_claim reaches this mapping and produces ClaimOutcome::RuntimeError rather than BudgetInterrupted. Consequently, required_floor_runner.rs routes an unenrolled crossing into failures and an expected-red crossing through RuntimeErrored; if that identity is already enrolled in floor_non_verdict, the latter can even satisfy the non-verdict roster instead of populating the always-blocking interrupted_before_verdict collection. Preserve a distinct fill cause while retaining the interruption/budget fields and blocking semantics.
Useful? React with 👍 / 👎.
| /// An admitted cross-claim producer was the active subject when the unchanged CPU safety | ||
| /// ceiling fired. The token makes the prospective-fill population countable without | ||
| /// treating first-touch order as intrinsic claim cost. | ||
| FillBudgetExceeded, |
There was a problem hiding this comment.
This enum is documented as a one-for-one mirror of gunbc.observation_ci_render.CiWitnessRuntimeCause, but the authoritative enum in dag/gunbc/observation_ci_render.dag:831-851 and its token function have no fill-budget arm. Rust can therefore emit cause=fill-budget-exceeded while the modeled renderer and consumers cannot construct or recognize the corresponding cause, leaving the mirror/parity contract incomplete; add the modeled variant and token alongside this Rust arm.
Useful? React with 👍 / 👎.
Auto-opened by session-dashboard for session
jolly-ibex-643.Pushing to
session/jolly-ibex-643advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan