Repository navigation
FLOOR REPAIR: in-flight shared fill is charged as marginal until store — repair the classification boundary (design first, characterization is landed in docs/plans/required-floor-in-flight-shared-fill-findings.md) - #10003
Merged
Conversation
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FillBudgetExceededonly if subtracting the active prospective fill brings marginal claim CPU back within the limit. Otherwise retain ordinaryEvaluationBudgetExceeded.fill-budget-exceededcause token.AlreadyPresentis servable, not a publication refusal.This is an attribution repair and measurement instrument, not an availability exemption. A prospective fill over the limit still stops. Counting these refusals can provide evidence for a future separately modeled fill envelope; this PR creates no such policy.
The budget expression at the poll is only opened to retain the raw CPU sample needed for attribution: it remains exactly
thread_cpu_nanos() - shared_artifact_fill_cpu_nanos(), the existingbudgeted_cpu_nanos()clock.Discriminating evidence
The regression pair changes exactly one fact: resolved-identity admission. Both arms run the same compiled producer through the real evaluator under the same 5ms ceiling, and both cross it. The unadmitted arm retains
EvaluationBudgetExceeded; admitting that exact producer producesFillBudgetExceedednaming it.Test plan
cargo check -p v1-compiler— passed remotely.cargo test -p v1-compiler --lib admitted_in_flight_fill_crossing_is_typed_and_unadmitted_control_is_ordinary -- --nocapture— passed remotely.cargo fmt --all --check— passed in commit/push hooks.Worker attestation