Develop #27
Develop #27
Conversation
…te shell script for Python 3 compatibility (#123)
Release/v3.0.0
ci: Update workflow to run on Ubuntu instead of macOS
Release/v3.0.0
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -68,8 +66,7 @@ internal class TLDParser { | |||
| let hostComponents: [String] = host.lowercased().components(separatedBy: ".") | |||
| /// Search exceptions first, then search wildcards if not match | |||
| let matchClosure: (PSLData) -> Bool = { $0.matches(hostComponents: hostComponents) } | |||
| let pslData: PSLData? = self.pslDataSet.exceptions.first(where: matchClosure) ?? | |||
| self.pslDataSet.wildcards.first(where: matchClosure) | |||
| let pslData: PSLData? = self.pslDataSet.exceptions.first(where: matchClosure) ?? self.pslDataSet.wildcards.first(where: matchClosure) | |||
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 141 characters (line_length)
| @@ -68,8 +66,7 @@ internal class TLDParser { | |||
| let hostComponents: [String] = host.lowercased().components(separatedBy: ".") | |||
| /// Search exceptions first, then search wildcards if not match | |||
| let matchClosure: (PSLData) -> Bool = { $0.matches(hostComponents: hostComponents) } | |||
| let pslData: PSLData? = self.pslDataSet.exceptions.first(where: matchClosure) ?? | |||
| self.pslDataSet.wildcards.first(where: matchClosure) | |||
| let pslData: PSLData? = self.pslDataSet.exceptions.first(where: matchClosure) ?? self.pslDataSet.wildcards.first(where: matchClosure) | |||
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 141 characters (line_length)
| @@ -68,8 +66,7 @@ internal class TLDParser { | |||
| let hostComponents: [String] = host.lowercased().components(separatedBy: ".") | |||
| /// Search exceptions first, then search wildcards if not match | |||
| let matchClosure: (PSLData) -> Bool = { $0.matches(hostComponents: hostComponents) } | |||
| let pslData: PSLData? = self.pslDataSet.exceptions.first(where: matchClosure) ?? | |||
| self.pslDataSet.wildcards.first(where: matchClosure) | |||
| let pslData: PSLData? = self.pslDataSet.exceptions.first(where: matchClosure) ?? self.pslDataSet.wildcards.first(where: matchClosure) | |||
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 141 characters (line_length)
| _ expectedSecondDomain: String?, | ||
| _ expectedSubDomain: String?, | ||
| _ result: TLDResult?) { | ||
| func logTLDResult( |
There was a problem hiding this comment.
Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 6 (function_parameter_count)
| guard let input: T = input else { return } | ||
| let result: TLDResult? = tldExtractor.parse(input, quick: quick) | ||
|
|
||
| // logTLDResult(host, expectedRootDomain, expectedTopLevelDomain, expectedSecondDomain, expectedSubDomain, result) | ||
| // logTLDResult(host, expectedRootDomain, expectedTopLevelDomain, expectedSecondDomain, expectedSubDomain, result) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 129 characters (line_length)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 98.12% 98.13% +0.01%
==========================================
Files 4 4
Lines 160 161 +1
==========================================
+ Hits 157 158 +1
Misses 3 3 ☔ View full report in Codecov by Sentry. |
No description provided.