Release/v3.0.0 #24
Merged
Release/v3.0.0 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te shell script for Python 3 compatibility (#123)
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| _ expectedSecondDomain: String?, | ||
| _ expectedSubDomain: String?, | ||
| _ result: TLDResult?) { | ||
| func logTLDResult( |
There was a problem hiding this comment.
Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 6 (function_parameter_count)
| guard let input: T = input else { return } | ||
| let result: TLDResult? = tldExtractor.parse(input, quick: quick) | ||
|
|
||
| // logTLDResult(host, expectedRootDomain, expectedTopLevelDomain, expectedSecondDomain, expectedSubDomain, result) | ||
| // logTLDResult(host, expectedRootDomain, expectedTopLevelDomain, expectedSecondDomain, expectedSubDomain, result) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 129 characters (line_length)
| @@ -68,8 +66,7 @@ internal class TLDParser { | |||
| let hostComponents: [String] = host.lowercased().components(separatedBy: ".") | |||
| /// Search exceptions first, then search wildcards if not match | |||
| let matchClosure: (PSLData) -> Bool = { $0.matches(hostComponents: hostComponents) } | |||
| let pslData: PSLData? = self.pslDataSet.exceptions.first(where: matchClosure) ?? | |||
| self.pslDataSet.wildcards.first(where: matchClosure) | |||
| let pslData: PSLData? = self.pslDataSet.exceptions.first(where: matchClosure) ?? self.pslDataSet.wildcards.first(where: matchClosure) | |||
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 141 characters (line_length)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.