Conversation
added 21 commits
October 13, 2022 11:15
…s View or TopLevel
…lor scheme is null
6 tasks
added 8 commits
October 28, 2022 14:27
Collaborator
Author
|
@BDisp I think I'm going to merge this. View and TopLevel are mostly 'working'. However they don't work as well as Window and Dialog currently. So they only appear as options for Ctrl+N when running with Theres a lot more fiddling in this branch which is why I want it merged then I can begin refactoring and polishing properly without having to worry about merge constraints. |
BDisp
approved these changes
Oct 29, 2022
Contributor
|
I'm curious to see what coming next :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to make adding/editing
Viewclass easier. CurrentlyViewis invisible.Fixes #86
Fixes #76
This PR changes so that:
Viewthat is 'IsBorderlessContainerView' gets a green dotted border with a resize symbol.╬as it seems widely supportedTabViewwill not work/testable until Fixes #2071. DrawContentComplete event is never called from the base if it's overridden. Terminal.Gui#2072 is mergedTabViewis not reporting border click events in some situations (see Cannot 'click drag' resize TabView when tabs are on bottom #76). Maybe they are swallowed by bottom window instead of TabViewImportant: when comparing diff use 'Hide Whitespace differences' as I ran
Ctrl+K, Ctrl+D