Skip to content

Fixes #2071. DrawContentComplete event is never called from the base if it's overridden.#2072

Merged
tig merged 1 commit intogui-cs:developfrom
BDisp:drawcontentcomplete-fix
Sep 29, 2022
Merged

Fixes #2071. DrawContentComplete event is never called from the base if it's overridden.#2072
tig merged 1 commit intogui-cs:developfrom
BDisp:drawcontentcomplete-fix

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Sep 28, 2022

Fixes #2071 - The DrawContentComplete event is also needed be called from the views that overridden the Redraw method to do some action after drawn.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

Copy link
Copy Markdown
Member

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.

@tig tig merged commit 6739eea into gui-cs:develop Sep 29, 2022
@BDisp BDisp deleted the drawcontentcomplete-fix branch September 29, 2022 18:01
This was referenced Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DrawContentComplete event is never called from the base if it's overridden.

2 participants