Skip to content

Fixes #5453. Fix Windows VT input encoding for IME and non-ASCII characters #5454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BDisp merged 4 commits into from
Jun 1, 2026
+20 −0
Merged

Fixes #5453. Fix Windows VT input encoding for IME and non-ASCII characters #5454

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f31658
Fixes #5453. Fix Windows VT input encoding for IME and non-ASCII char…
BDisp May 30, 2026
d6a63c5
Potential fix for pull request finding
BDisp May 31, 2026
44010fb
Cleanup code
BDisp May 31, 2026
0496095
Apply suggested changes related with review feedback
BDisp May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions Terminal.Gui/Drivers/WindowsHelpers/WindowsVTInputHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ internal sealed class WindowsVTInputHelper : IDisposable
[DllImport ("kernel32.dll")]
private static extern uint GetConsoleCP ();

[DllImport ("kernel32.dll", SetLastError = true)]
private static extern bool SetConsoleCP (uint wCodePageID);

#endregion

private const int ERROR_NOT_FOUND = 1168;
Expand All @@ -68,6 +71,22 @@ internal sealed class WindowsVTInputHelper : IDisposable
private uint _originalConsoleMode;
private bool _disposed;

private const uint CP_UTF8 = 65001;

private readonly uint _originalConsoleCP;

public WindowsVTInputHelper ()
{
_originalConsoleCP = GetConsoleCP ();

if (_originalConsoleCP == CP_UTF8 || SetConsoleCP (CP_UTF8))
{
return;
}
int error = Marshal.GetLastWin32Error ();
Logging.Warning ($"{nameof (WindowsVTInputHelper)}: Failed to set console input code page to UTF-8. Win32 error: {error}");
}

/// <summary>
/// Gets whether VTS input mode was successfully enabled.
/// </summary>
Expand Down Expand Up @@ -238,6 +257,7 @@ public void Restore ()

try
{
SetConsoleCP (_originalConsoleCP);
Comment thread
BDisp marked this conversation as resolved.
SetConsoleMode (InputHandle, _originalConsoleMode);
IsEnabled = false;
}
Expand Down
Loading