Fixes #5453. Fix Windows VT input encoding for IME and non-ASCII characters#5454
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Windows ANSI/VT driver input decoding on Windows when the console input code page is not UTF-8, improving IME and non-ASCII character handling (Fixes #5453).
Changes:
- Add
SetConsoleCP(65001)support to force the console input code page to UTF-8 while using Windows VT input. - Track and restore the original console input code page during driver teardown.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tig
approved these changes
Jun 1, 2026
This was referenced Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed Changes/Todos
Verified manually by entering Chinese IME characters (腌) before and after the change. Prior to the fix the character was received as ?; after the fix the correct Unicode character is delivered to Terminal.Gui.
Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)