Fixes #4926. Remove IDriver.GetVersionInfo, add IDriver.KittyKeyboardCapabilities by Copilot · Pull Request #4927 · gui-cs/Terminal.Gui

Copilot · 2026-04-10T16:00:50Z

Removes IDriver.GetVersionInfo() (redundant with GetName()) and promotes kitty keyboard protocol state to a first-class IDriver property, eliminating the need for callers to cast to DriverImpl.

Proposed Changes/Todos

Remove GetVersionInfo() from IDriver and DriverImpl; update UICatalogRunnable to call GetName() directly with a null-safe fallback
Rename KittyKeyboardProtocolResult → KittyKeyboardCapabilities (file rename + class rename, updated XML docs)
Add KittyKeyboardCapabilities? KittyKeyboardCapabilities { get; } (get-only) to IDriver, following the same pattern as ColorCapabilities
DriverImpl implements the property as { get; private set; } with an internal void SetKittyKeyboardCapabilities() method — only MainLoopCoordinator (which holds a concrete DriverImpl) can update it, keeping capability detection authoritative
KittyKeyboardProtocolDetector.Detect() no longer directly assigns driver state — the detector only detects and invokes the callback
MainLoopCoordinator calls _driver?.SetKittyKeyboardCapabilities(result) when detection confirms support
All tests updated to use KittyKeyboardCapabilities type and driver.KittyKeyboardCapabilities property; Assert.NotNull added before accessing members to strengthen assertions

Pull Request checklist:

I've named my PR in the form of "Fixes #issue. Terse description."
My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
My code follows the Terminal.Gui library design guidelines
I ran dotnet test before commit
I have made corresponding changes to the API documentation (using /// style comments)
My changes generate no new warnings
I have checked my code and corrected any poor grammar or misspellings
I conducted basic QA to assure all features are working

…Capabilities Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/f93a30b7-6649-4c5a-95bd-014fb4f1eb2a Co-authored-by: tig <585482+tig@users.noreply.github.com>

Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/f93a30b7-6649-4c5a-95bd-014fb4f1eb2a Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot

Pull request overview

This PR updates the driver abstraction by removing IDriver.GetVersionInfo() and exposing kitty keyboard protocol detection results as a first-class IDriver.KittyKeyboardCapabilities property, eliminating the need for callers to reach into DriverImpl internals.

Changes:

Removed IDriver.GetVersionInfo() and updated the UICatalog status display to use GetName() instead.
Renamed KittyKeyboardProtocolResult to KittyKeyboardCapabilities and updated kitty keyboard detection plumbing to store capabilities on the driver.
Updated callers/tests to use the renamed type and the new IDriver property.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
Tests/UnitTestsParallelizable/Drivers/AnsiHandling/KittyKeyboardProtocolDetectorTests.cs	Updates tests to use `KittyKeyboardCapabilities` naming.
Tests/UnitTestsParallelizable/Application/MainLoopCoordinatorTests.cs	Updates assertions to use `driver.KittyKeyboardCapabilities`.
Terminal.Gui/Drivers/IDriver.cs	Removes `GetVersionInfo()` and adds `KittyKeyboardCapabilities` to the public interface.
Terminal.Gui/Drivers/DriverImpl.cs	Removes `GetVersionInfo()` implementation and stores detected kitty keyboard capabilities.
Terminal.Gui/Drivers/AnsiHandling/KittyKeyboardProtocolDetector.cs	Renames detection result type usage to `KittyKeyboardCapabilities`.
Terminal.Gui/Drivers/AnsiHandling/KittyKeyboardCapabilities.cs	Renames the capabilities/result type and updates XML docs.
Terminal.Gui/App/MainLoop/MainLoopCoordinator.cs	Stores detected kitty keyboard capabilities via the new setter.
Examples/UICatalog/UICatalogRunnable.cs	Replaces `GetVersionInfo()` with `GetName()` for display.

Comments suppressed due to low confidence (1)

Terminal.Gui/Drivers/AnsiHandling/KittyKeyboardCapabilities.cs:22

KittyKeyboardCapabilities is now exposed via the public IDriver API, but its properties have public setters. This allows any consumer to mutate IsSupported/SupportedFlags/EnabledFlags and potentially put the driver into an invalid state. Consider making the type immutable (get/init-only) or restricting setters (e.g., internal/private set) and updating internal code accordingly.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…bil' of tig:gui-cs/Terminal.Gui into copilot/remove-get-version-info-add-kitty-keyboard-capabil

Centralize Kitty keyboard enable/disable logic in KittyKeyboardProtocolDetector, removing it from AnsiOutput. Simplify KittyKeyboardCapabilities by replacing SupportedFlags and EnabledFlags with a single Flags property. Update MainLoopCoordinator and driver to use the new API, and make KittyKeyboardCapabilities settable on IDriver. Update all usages and tests to use the new Flags property. Remove obsolete code and tests from AnsiOutput. Improve logging and tracing for Kitty protocol detection and driver initialization. Update Keys scenario and UICatalogRunnable to display Kitty protocol status using the new approach.

Enhances driver and main loop to reliably enable kitty keyboard mode on startup (with post-enable detection of actual flags) and disable it on shutdown before disposing output. Updates KittyKeyboardProtocolDetector to confirm and store enabled flags. Reduces debug output by commenting trace lines. Updates docs to clarify negotiation and shutdown flow. Adds/updates tests to verify enable/disable sequences and capability updates.

…-keyboard-capabil

Added a new test region to KittyKeyboardPipelineTests to ensure no duplicate KeyDown events are raised when both Kitty CSI-u sequences and legacy printable characters are received for the same keypress. Tests cover generic printable keys, Portuguese keyboard characters, and Kitty sequences with associated text, addressing terminal behaviors that emit both input types.

…nput Added suppression logic in AnsiInputProcessor to prevent duplicate keydown events when both Kitty CSI-u and legacy printable sequences are received for the same key. Introduced virtual methods in InputProcessorImpl for customizable suppression. Updated related tests for style consistency.

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 12 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…r.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ity to DriverImpl.SetKittyKeyboardCapabilities Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/3b2bd475-1a29-40c5-877b-3b81ae948a10 Co-authored-by: tig <585482+tig@users.noreply.github.com>

…bil' of tig:gui-cs/Terminal.Gui into copilot/remove-get-version-info-add-kitty-keyboard-capabil

BDisp

Well planned and implemented. Converting isolated characters to a CSI-u sequence on the keydown event is a truly elegant solution. Thanks.

Initial plan

101172d

Copilot AI assigned Copilot and tig Apr 10, 2026

Copilot started work on behalf of tig April 10, 2026 16:00 View session

Copilot AI linked an issue Apr 10, 2026 that may be closed by this pull request

IDriver.GetVersionInfo is not needed. Add IDriver.KittyKeyboardCapabilities which is a refactoring of KittyKeyboardProtocol and KittyKeyboardProtocolResult #4926

Closed

Copilot AI and others added 2 commits April 10, 2026 16:06

Fix parameter name in SetKittyKeyboardCapabilities xml doc

8804937

Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/f93a30b7-6649-4c5a-95bd-014fb4f1eb2a Co-authored-by: tig <585482+tig@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Remove IDriver.GetVersionInfo and add IDriver.KittyKeyboardCapabilities~~ Fixes #3999. Remove IDriver.GetVersionInfo, add IDriver.KittyKeyboardCapabilities Apr 10, 2026

Copilot AI requested a review from tig April 10, 2026 16:08

Copilot finished work on behalf of tig April 10, 2026 16:08

tig requested a review from Copilot April 10, 2026 19:07

Copilot started reviewing on behalf of tig April 10, 2026 19:07 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Comment thread Terminal.Gui/Drivers/IDriver.cs Outdated

Comment thread Tests/UnitTestsParallelizable/Application/MainLoopCoordinatorTests.cs Outdated

Comment thread Examples/UICatalog/UICatalogRunnable.cs Outdated

tig and others added 4 commits April 10, 2026 15:04

Apply suggestions from code review

b7b898c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'copilot/remove-get-version-info-add-kitty-keyboard-capa…

43a9968

…bil' of tig:gui-cs/Terminal.Gui into copilot/remove-get-version-info-add-kitty-keyboard-capabil

tig changed the title ~~Fixes #3999. Remove IDriver.GetVersionInfo, add IDriver.KittyKeyboardCapabilities~~ Fixes #4926. Remove IDriver.GetVersionInfo, add IDriver.KittyKeyboardCapabilities Apr 11, 2026

tig added 3 commits April 10, 2026 21:09

Merge branch 'develop' into copilot/remove-get-version-info-add-kitty…

12a5ab0

…-keyboard-capabil

tig marked this pull request as ready for review April 11, 2026 04:04

tig requested review from BDisp and Copilot April 11, 2026 04:05

tig mentioned this pull request Apr 11, 2026

Fixes #4917. Kitty Keyboard Protocol doesn't works with AltGr and with empty fields #4919

Merged

10 tasks

Copilot started reviewing on behalf of tig April 11, 2026 04:06 View session

Copilot AI reviewed Apr 11, 2026

View reviewed changes

Copilot started work on behalf of tig April 11, 2026 04:14 View session

tig and others added 2 commits April 10, 2026 22:14

Update Terminal.Gui/Drivers/IDriver.cs

87d3460

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update Terminal.Gui/Drivers/AnsiHandling/KittyKeyboardProtocolDetecto…

0cc01c9

…r.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

tig and others added 4 commits April 10, 2026 22:15

Update Terminal.Gui/Drivers/AnsiHandling/KittyKeyboardCapabilities.cs

1b6d559

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update Terminal.Gui/App/MainLoop/MainLoopCoordinator.cs

ff8c872

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update Terminal.Gui/App/MainLoop/ApplicationMainLoop.cs

e44db68

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot finished work on behalf of tig April 11, 2026 04:22

Copilot started work on behalf of tig April 11, 2026 04:23 View session

Copilot finished work on behalf of tig April 11, 2026 04:24

tig added 2 commits April 11, 2026 16:43

Merge branch 'copilot/remove-get-version-info-add-kitty-keyboard-capa…

94fa70b

…bil' of tig:gui-cs/Terminal.Gui into copilot/remove-get-version-info-add-kitty-keyboard-capabil

deleted old plans

ef240a0

BDisp approved these changes Apr 11, 2026

View reviewed changes

tig merged commit e532d61 into develop Apr 11, 2026
11 checks passed

tig deleted the copilot/remove-get-version-info-add-kitty-keyboard-capabil branch April 11, 2026 19:32

This was referenced May 1, 2026

Bump the dotnet-dependencies group with 13 updates jntm7/pitterm#6

Open

Bump Terminal.Gui from 1.19.0 to 2.0.1 jas88/RDMP#205

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #4926. Remove IDriver.GetVersionInfo, add IDriver.KittyKeyboardCapabilities#4927

Fixes #4926. Remove IDriver.GetVersionInfo, add IDriver.KittyKeyboardCapabilities#4927
tig merged 18 commits intodevelopfrom
copilot/remove-get-version-info-add-kitty-keyboard-capabil

Copilot AI commented Apr 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BDisp left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes/Todos

Pull Request checklist:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BDisp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Apr 10, 2026 •

edited

Loading