Fixes #4917. Kitty Keyboard Protocol doesn't works with AltGr and with empty fields#4919
Conversation
Refactored Kitty keyboard protocol handling to use KittyKeyboardFlags in AnsiInput, added EnableKittyKeyboard method, and updated DriverImpl to synchronize enabled flags across input and output. Removed obsolete KittyProtocolEnabled property and improved logging/tracing for clarity.
tig
left a comment
There was a problem hiding this comment.
I pushed some changes to simplifiy enablement.
I'm confused about whether this is a WIndows only issue or not.
Do you know that it doesn't exist on other platforms?
|
Your commit c969d3f broke keyboard kitty support. Please review it. Thanks. |
|
@BDisp please remove the fix for #4918 from this PR. Your fix is not at the right level and adds unnecessary coupling of kitty specific details into the IInput/AnsiInput code. Your fixes for the other two issues are fine though. The correct solution to #4918 needs to go in I have a robust set of tests and fix in #4927. |
|
I already remove all the changes related with the #4918. I hope I didn't breaking anything. Thanks. |
Fixes
Proposed Changes/Todos
Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)