Fixes #2156 - BREAKING CHANGE - Fixes IsOverridden and makes it internal#2158
Merged
tig merged 11 commits intogui-cs:developfrom Nov 2, 2022
Merged
Fixes #2156 - BREAKING CHANGE - Fixes IsOverridden and makes it internal#2158tig merged 11 commits intogui-cs:developfrom
tig merged 11 commits intogui-cs:developfrom
Conversation
Fixes 2140 onselectedchange per @tig
…to fixes_2140_onselectedchange
tig
added
the
breaking-change
Member
Author
|
Since other PRs are dependent on this, I'm merging it now. We can back it out if someone has problems with how I did it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2156
BREAKING CHANGE -
This PR
I used cs.github.com to gain confidence that no-one outside of core code uses this function.
If someone wants to use it, they can code it up themselves... It is very bad OO practice to do something like this and we should not encourage it. In v2 we should figure out how to restructure things so it can be completely removed.