Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force corepack version to fix CI actions errors #1774

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

emma-imber
Copy link
Contributor

What does this change?

Forces specific version of corepack to fix CI actions errors. Copying what was done here: https://github.com/guardian/ad-manager-line-items-jobs/pull/19

@emma-imber emma-imber requested a review from a team as a code owner February 3, 2025 11:22
Copy link

changeset-bot bot commented Feb 3, 2025

⚠️ No Changeset found

Latest commit: 92de2ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Ad load time test results

For consented, top-above-nav took on average 4204ms to load.
For consentless, top-above-nav took on average 3545ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@emma-imber emma-imber merged commit 7c599a0 into main Feb 3, 2025
14 checks passed
@emma-imber emma-imber deleted the ei/fix-corepack branch February 3, 2025 11:35
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @emma-imber 1 minute and 59 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants