Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liveblog-top ad sizes #1440

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Add liveblog-top ad sizes #1440

merged 2 commits into from
Jun 26, 2024

Conversation

Jakeii
Copy link
Member

@Jakeii Jakeii commented Jun 26, 2024

What does this change?

Add sizes for new slot that will appear at the top of liveblogs, only when targeted with an ad.

@Jakeii Jakeii requested a review from a team as a code owner June 26, 2024 09:07
Copy link

changeset-bot bot commented Jun 26, 2024

🦋 Changeset detected

Latest commit: a241e7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/commercial Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Ad load time test results

For consented, top-above-nav took on average 4371ms to load.
For consentless, top-above-nav took on average 3220ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@Jakeii Jakeii merged commit 3249b47 into main Jun 26, 2024
13 checks passed
@Jakeii Jakeii deleted the jlk/liveblog-top-slot branch June 26, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants