Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cd: Fix env var reference #2081

Merged
merged 1 commit into from
Oct 30, 2023
Merged

cd: Fix env var reference #2081

merged 1 commit into from
Oct 30, 2023

Conversation

akash1810
Copy link
Member

@akash1810 akash1810 commented Oct 30, 2023

What does this change?

Following the changes in #2071, the release of the GitHub Pages site during CD has broken:

image

This change updates how GITHUB_REPOSITORY is referenced to fix the build. https://docs.github.com/en/actions/security-guides/automatic-token-authentication#example-2-calling-the-rest-api used for inspiration.

How to test

It's a bit difficult to test as this part of the workflow has a condition to only run on the main branch. The real test will happen upon merge.

I've run the workflow manually to ensure the syntax is valid.

How can we measure success?

CD works again.

Have we considered potential risks?

N/A

Checklist

  • I have listed any breaking changes, along with a migration path 1
  • I have updated the documentation as required for the described changes 2

Footnotes

  1. Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs.

  2. If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid?

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023

⚠️ No Changeset found

Latest commit: 42f9f7e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Updates how `GITHUB_TOKEN` and `GITHUB_REPOSITORY` are referenced to fix the build.

tschaub/gh-pages#345 (comment) used for inspiration.
@akash1810 akash1810 marked this pull request as ready for review October 30, 2023 10:04
@akash1810 akash1810 requested a review from a team as a code owner October 30, 2023 10:04
@akash1810 akash1810 requested a review from joecowton1 October 30, 2023 10:04
@akash1810 akash1810 merged commit 16f696f into main Oct 30, 2023
3 checks passed
@akash1810 akash1810 deleted the akash1810-patch-1 branch October 30, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants