Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented the REST API #1452

Merged
merged 11 commits into from
Nov 15, 2023
Merged

Implemented the REST API #1452

merged 11 commits into from
Nov 15, 2023

Conversation

nathannaveen
Copy link
Contributor

@nathannaveen nathannaveen commented Oct 31, 2023 •
edited
Loading

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen nathannaveen force-pushed the nathan/implementREST branch 4 times, most recently from 33cf8c0 to 95b8266 Compare November 6, 2023 21:38
@jeffmendoza
Copy link
Collaborator

This is awesome! Please add an "EXPERIMENTAL!" warning to both the guacrest entry in cmd/README.md and at the top of cmd/guacrest/README.md.

Also, see "Additional context" here "require an experimental env var to be set to run." Check for an environment variable GUAC_EXPERIMENTAL to be set to true before running in main.go and exit with an explanation if not set.

You may go ahead and update the Makefile to build guacrest in this PR or a followup.

@nathannaveen
Copy link
Contributor Author

This is awesome! Please add an "EXPERIMENTAL!" warning to both the guacrest entry in cmd/README.md and at the top of cmd/guacrest/README.md.

Also, see "Additional context" here "require an experimental env var to be set to run." Check for an environment variable GUAC_EXPERIMENTAL to be set to true before running in main.go and exit with an explanation if not set.

You may go ahead and update the Makefile to build guacrest in this PR or a followup.

Thanks! I have done that!

I have to still get the swagger documents up, I am currently waiting on swaggo/swag#1696.

jeffmendoza
jeffmendoza approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@jeffmendoza jeffmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a quick Makefile update.

Makefile Outdated Show resolved Hide resolved
@nathannaveen nathannaveen force-pushed the nathan/implementREST branch 2 times, most recently from b534398 to baf3e38 Compare November 15, 2023 14:53
@nathannaveen
Implemented the REST API
6dc2bfe 
* Fixes guacsec#1326
* Implemented the REST API for Known
*

Fixed docker-compose down

When running `make stop-service` I was getting:

```
make stop-service
docker compose down
service "oci-collector" depends on undefined service guac-graphql: invalid compose project
make: *** [stop-service] Error 15
```

This is because the guac-graphql was removed from, 8336525.

Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Added comments to vuln to improve readability
0c94638 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Basic REST API for Bad
7c811ad 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Updated to include visualizer url
3413db0 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Updated docs
94cde1e 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Included Tests for Bad
f4b69fe 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Updated based on comment
f7a3fa7 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Updated Makefile
40d743d 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Ignored other operating systems for goreleaser
3d62ec1 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Included Swagger docs
f46f09a 
Signed-off-by: nathannaveen <[email protected]>
@pxp928
Copy link
Collaborator

pxp928 commented Nov 15, 2023

@nathannaveen just need to fix the static analysis check

@nathannaveen
Fixed fmt
5a55af6 
Signed-off-by: nathannaveen <[email protected]>
@kodiakhq kodiakhq bot merged commit 1e5a333 into guacsec:main Nov 15, 2023
8 checks passed
@funnelfiasco funnelfiasco mentioned this pull request Jun 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Experimental Advanced Query REST API
3 participants
@nathannaveen @jeffmendoza @pxp928