-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Experimental Advanced Query REST API #1326
Comments
I would like to work on this. |
+1 on the proposal. I think this is quite a sizable feature and it'd be nice to have a design doc explaining a bit more about the mechanics of how this would work (both from an infrastructure level, as well as the dependencies of the other GUAC components and libraries). |
I am working on the REST APIs design and code (it experimental). Here is the design doc, https://github.com/nathannaveen/guac/blob/nathan/implementREST/cmd/rest/design.md. |
* Fixes guacsec#1326 * Implemented the REST API for Known *
* Fixes guacsec#1326 * Implemented the REST API for Known * Fixed docker-compose down When running `make stop-service` I was getting: ``` make stop-service docker compose down service "oci-collector" depends on undefined service guac-graphql: invalid compose project make: *** [stop-service] Error 15 ``` This is because the guac-graphql was removed from, 8336525. Signed-off-by: nathannaveen <[email protected]>
* Fixes guacsec#1326 * Implemented the REST API for Known * Fixed docker-compose down When running `make stop-service` I was getting: ``` make stop-service docker compose down service "oci-collector" depends on undefined service guac-graphql: invalid compose project make: *** [stop-service] Error 15 ``` This is because the guac-graphql was removed from, 8336525. Signed-off-by: nathannaveen <[email protected]>
* Fixes guacsec#1326 * Implemented the REST API for Known * Fixed docker-compose down When running `make stop-service` I was getting: ``` make stop-service docker compose down service "oci-collector" depends on undefined service guac-graphql: invalid compose project make: *** [stop-service] Error 15 ``` This is because the guac-graphql was removed from, 8336525. Signed-off-by: nathannaveen <[email protected]>
* Fixes guacsec#1326 * Implemented the REST API for Known * Fixed docker-compose down When running `make stop-service` I was getting: ``` make stop-service docker compose down service "oci-collector" depends on undefined service guac-graphql: invalid compose project make: *** [stop-service] Error 15 ``` This is because the guac-graphql was removed from, 8336525. Signed-off-by: nathannaveen <[email protected]>
* Fixes guacsec#1326 * Implemented the REST API for Known * Fixed docker-compose down When running `make stop-service` I was getting: ``` make stop-service docker compose down service "oci-collector" depends on undefined service guac-graphql: invalid compose project make: *** [stop-service] Error 15 ``` This is because the guac-graphql was removed from, 8336525. Signed-off-by: nathannaveen <[email protected]>
* Implemented the REST API * Fixes #1326 * Implemented the REST API for Known * Fixed docker-compose down When running `make stop-service` I was getting: ``` make stop-service docker compose down service "oci-collector" depends on undefined service guac-graphql: invalid compose project make: *** [stop-service] Error 15 ``` This is because the guac-graphql was removed from, 8336525. Signed-off-by: nathannaveen <[email protected]> * Added comments to vuln to improve readability Signed-off-by: nathannaveen <[email protected]> * Basic REST API for Bad Signed-off-by: nathannaveen <[email protected]> * Updated to include visualizer url Signed-off-by: nathannaveen <[email protected]> * Updated docs Signed-off-by: nathannaveen <[email protected]> * Included Tests for Bad Signed-off-by: nathannaveen <[email protected]> * Updated based on comment Signed-off-by: nathannaveen <[email protected]> * Updated Makefile Signed-off-by: nathannaveen <[email protected]> * Ignored other operating systems for goreleaser Signed-off-by: nathannaveen <[email protected]> * Included Swagger docs Signed-off-by: nathannaveen <[email protected]> * Fixed fmt Signed-off-by: nathannaveen <[email protected]> --------- Signed-off-by: nathannaveen <[email protected]>
Is your feature request related to a problem? Please describe.
GUAC users and community members continue to identify novel questions or solutions that GUAC will enable answering. Not all of these translate into a single GraphQL query. Also, not all users are interested in learning GraphQL and crafting complex queries.
Example of these are in the
guacone query
cli command, however users want to be able to call this from other programs or scripts. GUAC should provide a "callabe" interface to the advanced queries that require filtering and/or graph traversal.Describe the solution you'd like
A new guac binary that will serve an http REST API. Endpoints will be advanced queries that query GUAC GraphQL and return answers. Starting queries will be the same as in the guacone cli:
More advanced filters and conditions can be added to these. Also more queries can be added as well.
Describe alternatives you've considered
More advanced queries can be added as new queries directly to GUAC's GraphQL API.
Additional context
Initial discussion is to move forward with a new binary under
cmd/
. Update theMakefile
to build it, but don't add it to release. Also, require an experimental env var to be set to run. The API should support both OpenAPI and be compatible/translatable to protobuf. Moving forward does not preclude the alternative above and will be treated as an experiment.The text was updated successfully, but these errors were encountered: