Warn instead of failing when constructing metadata from remote end #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasnoble
approved these changes
Jul 11, 2019
Merged
alexander-fenster
added a commit
to googleapis/gax-nodejs
that referenced
this pull request
Jul 12, 2019
This fix includes grpc/grpc-node#962 which is a work around for a bad metadata keys problem that many customer see across several libraries (googleapis/nodejs-datastore#415, googleapis/nodejs-logging#527, googleapis/nodejs-pubsub#667 are just a few).
3 tasks
JustinBeckwith
pushed a commit
to googleapis/gax-nodejs
that referenced
this pull request
Jul 12, 2019
This fix includes grpc/grpc-node#962 which is a work around for a bad metadata keys problem that many customer see across several libraries (googleapis/nodejs-datastore#415, googleapis/nodejs-logging#527, googleapis/nodejs-pubsub#667 are just a few).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to preserve the invariant that any
Metadataobject is always a valid set of gRPC metadata. googleapis/nodejs-datastore#415 indicates that we need to handle the case where thehttp2module invalidly mangles the headers. We should try to do as much as possible, but erroring out when something goes wrong is probably to onerous for our users. So, we emit a warning and omit the problematic metadata entry from the resulting metadata object.The added
exportis completely separate. VSCode complained about it not being there.