Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @grpc/grpc-js to ^0.5.2 #532

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

alexander-fenster
Copy link
Contributor

This fix includes grpc/grpc-node#962 which is a work around for a bad metadata keys problem that many customer see across several libraries (googleapis/nodejs-datastore#415, googleapis/nodejs-logging#527, googleapis/nodejs-pubsub#667 are just a few).

Fixes googleapis/nodejs-datastore#415
Fixes googleapis/nodejs-logging#527

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

This fix includes grpc/grpc-node#962 which is a work around for a bad metadata keys problem that many customer see across several libraries (googleapis/nodejs-datastore#415, googleapis/nodejs-logging#527, googleapis/nodejs-pubsub#667 are just a few).
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 12, 2019
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2019
@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #532 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #532   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files          52       52           
  Lines        3488     3488           
  Branches      267      267           
=======================================
  Hits         2885     2885           
  Misses        537      537           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c4034...97742a4. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit a4be4e1 into master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GRPC-JS Error: Metadata key contains illegal characters Metadata key contains illegal characters
4 participants