Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create prebuilts for native electron 10 and 11 #1684

Merged
merged 5 commits into from
Feb 8, 2021
Merged

Create prebuilts for native electron 10 and 11 #1684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
928d2d5
Native: add new Electron versions, bump version
jmeinke Feb 4, 2021
f879313
Native: add new Electron versions -> apply suggestions
jmeinke Feb 5, 2021
69be33c
Native: add new Electron versions -> always use latest v1 of microsof…
jmeinke Feb 6, 2021
4d83f4e
Native: add new Electron versions -> update info about latest version…
jmeinke Feb 6, 2021
f73b869
Native: add new Electron versions -> fix microsoft/setup-msbuild to v1
jmeinke Feb 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ jobs:
- uses: actions/checkout@v2
with:
submodules: recursive
- uses: actions/setup-node@v1.4.2
- uses: actions/setup-node@v2
with:
node-version: 14
- name: Setup MSBuild
uses: microsoft/setup-msbuild@v1.0.0
uses: microsoft/setup-msbuild@v1
if: ${{matrix.os == 'windows-latest'}}
- name: Build
run: packages/grpc-native-core/tools/run_tests/artifacts/build_one_artifact_${{matrix.os}}.sh
Expand All @@ -46,7 +46,7 @@ jobs:
name: All Electron Builds
strategy:
matrix:
electron: ['1.0', '1.1', '1.2', '1.3', '1.4', '1.5', '1.6', '1.7', '1.8', '2.0', '3.0', '3.1', '4.1', '4.2', '5.0', '6.0', '6.1', '7.0', '7.1', '7.2', '7.3', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5', '9.0', '9.1', '9.2', '9.3', '10.0', '10.1']
electron: ['1.0', '1.1', '1.2', '1.3', '1.4', '1.5', '1.6', '1.7', '1.8', '2.0', '3.0', '3.1', '4.1', '4.2', '5.0', '6.0', '6.1', '7.0', '7.1', '7.2', '7.3', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5', '9.0', '9.1', '9.2', '9.3', '10.0', '10.1', '10.2', '10.3', '11.0', '11.1', '11.2']
arch: [ia32, x64]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{matrix.os}}
Expand All @@ -59,11 +59,11 @@ jobs:
- uses: actions/checkout@v2
with:
submodules: recursive
- uses: actions/setup-node@v1.4.2
- uses: actions/setup-node@v2
with:
node-version: 14
- name: Setup MSBuild
uses: microsoft/setup-msbuild@v1.0.0
uses: microsoft/setup-msbuild@v1
if: ${{matrix.os == 'windows-latest'}}
- name: Build
run: packages/grpc-native-core/tools/run_tests/artifacts/build_one_artifact_${{matrix.os}}.sh
Expand Down Expand Up @@ -131,4 +131,4 @@ jobs:
- uses: actions/upload-artifact@v2
with:
name: combined-artifacts
path: artifacts/
path: artifacts/
2 changes: 1 addition & 1 deletion packages/grpc-native-core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
## LATEST VERSIONS SUPPORTED

- Node: 14
- Electron: 10.1
- Electron: 11.2

## INSTALLATION

Expand Down
2 changes: 1 addition & 1 deletion packages/grpc-native-core/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
'GPR_BACKWARDS_COMPATIBILITY_MODE',
'GRPC_ARES=1',
'GRPC_UV',
'GRPC_NODE_VERSION="1.24.4"',
'GRPC_NODE_VERSION="1.24.5"',
'CARES_STATICLIB',
'CARES_SYMBOL_HIDING'
],
Expand Down
2 changes: 1 addition & 1 deletion packages/grpc-native-core/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
settings:
'#': It's possible to have node_version here as a key to override the core's version.
node_version: 1.24.4
node_version: 1.24.5
2 changes: 1 addition & 1 deletion packages/grpc-native-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "grpc",
"version": "1.24.4",
"version": "1.24.5",
"author": "Google Inc.",
"description": "gRPC Library for Node",
"homepage": "https://grpc.io/",
Expand Down