-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create prebuilts for native electron 10 and 11 #1684
Create prebuilts for native electron 10 and 11 #1684
Conversation
|
It looks like some build issues have appeared since we last used this build script. I think it will help if you change |
It looks like it will also be necessary to upgrade |
…t/setup-msbuild action
6c26e9c
to
69be33c
Compare
1a534cf
to
f73b869
Compare
@murgatroid99 The build was successful 🎉 Thanks for your help on fixing the build issues - it would be great if you could release this soon-ish 😃 |
This PR would help us a lot! |
@murgatroid99 Could you please release the version to NPM. Thank you! |
It's out now. |
Thanks! |
Because of this issue, we can't rely on grpc-js: #1158 (comment)
Therefore, it would be great if you could release a grpc native version with prebuilt binaries for Electron 10.3 or Electron v11.