Cherry pick fix for CVE-2026-33186 for 1.66.x (grpc-ui vuln.)#9024
Cherry pick fix for CVE-2026-33186 for 1.66.x (grpc-ui vuln.)#9024olegbonar wants to merge 1 commit intogrpc:v1.66.xfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.66.x #9024 +/- ##
===========================================
- Coverage 81.94% 81.81% -0.13%
===========================================
Files 361 361
Lines 27862 27876 +14
===========================================
- Hits 22831 22808 -23
- Misses 3841 3865 +24
- Partials 1190 1203 +13
🚀 New features to boost your workflow:
|
|
The failures on the PR are branch-level CI issues, not caused by the cherry-pick, I think. |
|
The 1.66 release went out in Aug-Sep of 2024. That's about a year and a half old. Why do you want to cherrypick this fix into a branch that old? |
|
@easwars we were lucky enough to run into this CVE in the fullstorydev/grpcui package, which uses exactly 1.66.x still, sadly. |
|
Have you had a chance to check with the fullstorydev/grpcui package to see if they can upgrade? Otherwise, you should be able to change your go.mod to depend on the latest grpc release that contains the fix. Unfortunately, 1.66 is too old according to our policy. See our FAQ: https://grpc.io/docs/what-is-grpc/faq/#how-long-are-grpc-releases-supported-for |
Summary
Server.handleStream, rejecting gRPC requests with method names that do not start with/as required by the gRPCover HTTP/2 spec
GRPC_GO_EXPERIMENTAL_DISABLE_STRICT_PATH_CHECKING=true; this will be removed in a future releaseTest plan
TestMalformedMethodPathvalidates all combinations of malformed paths and env var settings