Skip to content

Cherry pick fix for CVE-2026-33186 for 1.66.x (grpc-ui vuln.)#9024

Closed
olegbonar wants to merge 1 commit intogrpc:v1.66.xfrom
olegbonar:fix-cve-2026-33186
Closed

Cherry pick fix for CVE-2026-33186 for 1.66.x (grpc-ui vuln.)#9024
olegbonar wants to merge 1 commit intogrpc:v1.66.xfrom
olegbonar:fix-cve-2026-33186

Conversation

@olegbonar
Copy link
Copy Markdown

Summary

Test plan

  • New test TestMalformedMethodPath validates all combinations of malformed paths and env var settings
  • Verify existing tests pass with no regressions

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.81%. Comparing base (85ec11d) to head (03a3635).

Files with missing lines Patch % Lines
server.go 61.53% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           v1.66.x    #9024      +/-   ##
===========================================
- Coverage    81.94%   81.81%   -0.13%     
===========================================
  Files          361      361              
  Lines        27862    27876      +14     
===========================================
- Hits         22831    22808      -23     
- Misses        3841     3865      +24     
- Partials      1190     1203      +13     
Files with missing lines Coverage Δ
internal/envconfig/envconfig.go 100.00% <ø> (ø)
server.go 82.10% <61.53%> (-0.35%) ⬇️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@olegbonar
Copy link
Copy Markdown
Author

The failures on the PR are branch-level CI issues, not caused by the cherry-pick, I think.

@easwars
Copy link
Copy Markdown
Contributor

easwars commented Mar 27, 2026

The 1.66 release went out in Aug-Sep of 2024. That's about a year and a half old. Why do you want to cherrypick this fix into a branch that old?

@olegbonar
Copy link
Copy Markdown
Author

@easwars we were lucky enough to run into this CVE in the fullstorydev/grpcui package, which uses exactly 1.66.x still, sadly.

@easwars
Copy link
Copy Markdown
Contributor

easwars commented Mar 27, 2026

Have you had a chance to check with the fullstorydev/grpcui package to see if they can upgrade?

Otherwise, you should be able to change your go.mod to depend on the latest grpc release that contains the fix.

Unfortunately, 1.66 is too old according to our policy. See our FAQ: https://grpc.io/docs/what-is-grpc/faq/#how-long-are-grpc-releases-supported-for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants