grpc: enforce strict path checking for incoming requests on the server#8985
Merged
easwars merged 1 commit intogrpc:masterfrom Mar 17, 2026
Merged
grpc: enforce strict path checking for incoming requests on the server#8985easwars merged 1 commit intogrpc:masterfrom
easwars merged 1 commit intogrpc:masterfrom
Conversation
grpc#8981) RELEASE NOTES: * server: fix an authorization bypass where malformed :path headers (missing the leading slash) could bypass path-based restricted "deny" rules in interceptors like `grpc/authz`. Any request with a non-canonical path is now immediately rejected with an `Unimplemented` error.
dfawley
approved these changes
Mar 17, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8985 +/- ##
==========================================
- Coverage 83.02% 82.94% -0.08%
==========================================
Files 411 411
Lines 32719 32733 +14
==========================================
- Hits 27164 27151 -13
- Misses 4165 4183 +18
- Partials 1390 1399 +9
🚀 New features to boost your workflow:
|
Contributor
|
@easwars we would also need to cherry-pick this change to the v1.80.x branch. |
Contributor
Author
Yes. I'm working on it as I'm typing this. |
easwars
added a commit
to easwars/grpc-go
that referenced
this pull request
Mar 18, 2026
grpc#8985) RELEASE NOTES: * server: fix an authorization bypass where malformed :path headers (missing the leading slash) could bypass path-based restricted "deny" rules in interceptors like `grpc/authz`. Any request with a non-canonical path is now immediately rejected with an `Unimplemented` error.
| @@ -103,6 +103,22 @@ var ( | |||
| // environment variable "GRPC_GO_EXPERIMENTAL_XDS_RESOURCE_PANIC_RECOVERY" | |||
| // to "false". | |||
| XDSRecoverPanicInResourceParsing = boolFromEnv("GRPC_GO_EXPERIMENTAL_XDS_RESOURCE_PANIC_RECOVERY", true) | |||
|
Is this the complete fix for CVE-2026-33186? |
Contributor
Author
Yes |
2 tasks
This was referenced Mar 27, 2026
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES:
grpc/authz. Any request with a non-canonical path is now immediately rejected with anUnimplementederror.