deps: update dependencies for all modules

[purnesh42H]

RELEASE NOTES: None

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.29%. Comparing base (f2d3e11) to head (6178fbf).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8331      +/-   ##
==========================================
- Coverage   82.41%   82.29%   -0.13%     
==========================================
  Files         419      419              
  Lines       42025    42025              
==========================================
- Hits        34637    34585      -52     
- Misses       5944     5987      +43     
- Partials     1444     1453       +9     

see 25 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[arjan-bal]

Vet is failing, seems to be related to this PR. Can you PTAL?

[purnesh42H]

Vet is failing, seems to be related to this PR. Can you PTAL?

So, looks like there was version incompatibility with tableWriter module in the latest version of revive mgechev/revive#1345. Anyways, they fixed it by replacing the tableWriter with fmt.Sprintf() mgechev/revive#1351.

For our release I think we can skip upgrading the revive this time because otherwise we have to wait for their patch release. So, i have reverted the version bump for revive.

[arjan-bal]

Vet is failing, seems to be related to this PR. Can you PTAL?

So, looks like there was version incompatibility with tableWriter module in the latest version of revive mgechev/revive#1345. Anyways, they fixed it by replacing the tableWriter with fmt.Sprintf() mgechev/revive#1351.

For our release I think we can skip upgrading the revive because otherwise we have to wait for their patch release. So, i have reverted the version bump for revive.

Can you open an issue for this and add a TODO so that this issue is not forgotten?

[arjan-bal]

LGTM with a comment for opening a tracking issue for bumping revive later.

[purnesh42H]

Vet is failing, seems to be related to this PR. Can you PTAL?

So, looks like there was version incompatibility with tableWriter module in the latest version of revive mgechev/revive#1345. Anyways, they fixed it by replacing the tableWriter with fmt.Sprintf() mgechev/revive#1351.
For our release I think we can skip upgrading the revive because otherwise we have to wait for their patch release. So, i have reverted the version bump for revive.

Can you open an issue for this and add a TODO so that this issue is not forgotten?

Done

[purnesh42H]

Vet is failing, seems to be related to this PR. Can you PTAL?

So, looks like there was version incompatibility with tableWriter module in the latest version of revive mgechev/revive#1345. Anyways, they fixed it by replacing the tableWriter with fmt.Sprintf() mgechev/revive#1351.
For our release I think we can skip upgrading the revive because otherwise we have to wait for their patch release. So, i have reverted the version bump for revive.

Can you open an issue for this and add a TODO so that this issue is not forgotten?

Done

In general can we do the version bump after the release is published? In case of revive though its for internal use only. Would it still need to be done as part of patch release? or we just wait for next minor release? @dfawley cc

[arjan-bal]

In general can we do the version bump after the release is published? In case of revive though its for internal use only. Would it still need to be done as part of patch release? or we just wait for next minor release? @dfawley cc

We are bumping the dep on master (not a release branch), I don't think we need to worry about patch releases here. We can bump this dependency at any point in the future.

[purnesh42H]

In general can we do the version bump after the release is published? In case of revive though its for internal use only. Would it still need to be done as part of patch release? or we just wait for next minor release? @dfawley cc

We are bumping the dep on master (not a release branch), I don't think we need to worry about patch releases here. We can bump this dependency at any point in the future.

yeah for revive we need bump only on master branch