cleanup: replace dial with newclient by janardhanvissa · Pull Request #7967 · grpc/grpc-go

janardhanvissa · 2024-12-25T11:52:59Z

Partially address: #7049

RELEASE NOTES: None

codecov · 2024-12-25T11:57:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.32%. Comparing base (ae2a04f) to head (b55f656).
Report is 16 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7967      +/-   ##
==========================================
+ Coverage   82.29%   82.32%   +0.03%     
==========================================
  Files         387      387              
  Lines       38967    38941      -26     
==========================================
- Hits        32066    32057       -9     
+ Misses       5586     5574      -12     
+ Partials     1315     1310       -5

see 45 files with indirect coverage changes

This reverts commit 506fd98, reversing changes made to d520f73.

…pc-go" This reverts commit 0486355, reversing changes made to 7ddbe46.

…rpc-go" This reverts commit fd2860b.

This reverts commit f1ec518.

This reverts commit 506fd98, reversing changes made to d520f73.

janardhanvissa · 2025-02-20T23:55:31Z

All the above comments are addressed. Please re-review once,

janardhanvissa · 2025-02-27T21:43:35Z

@easwars All the above mentioned were addressed. Please re-review once.

easwars

LGTM modulo minor nits.

cds: stop child policies on resource-not-found errors (grpc#8122) xds: simplify code handling certain error conditions in the resolver (grpc#8123) xds, pickfirst: Enable additional addresses in xDS, set new pick_first as default (grpc#8126) github: change test action to cover the legacy pickfirst balancer (grpc#8129) cleanup: replace dial with newclient (grpc#7967) cleanup: replace dial with newclient (grpc#7970) stats/openetelemetry: refactor and make e2e test stats verification deterministic (grpc#8077) xds: introduce simple grpc transport for generic xds clients (grpc#8066) xds: generic xds client common configs re-push comments improve ServerConfig equal easwar review round 1 on documentation easwar comments on docstrings easwar comments round 4 config tests merge with previous pr xds: add lrs client and xDS client interfaces second pass to documentation language change from godoc review dfawley review 2 easwar review 1 changed to decoder struct move authorities under xds client easwar review 2 easwars review 4 ResourceWatcher done and LoadStore stop grpc based transport remove server config extension interface add byte codec dfawley review 1 send and recv tests with byte based test server change to proto based server easwar review 1 easwar review 3 xds: generic xds client ads transport channel

ads: stop child policies on resource-not-found errors (grpc#8122) xds: simplify code handling certain error conditions in the resolver (grpc#8123) xds, pickfirst: Enable additional addresses in xDS, set new pick_first as default (grpc#8126) github: change test action to cover the legacy pickfirst balancer (grpc#8129) cleanup: replace dial with newclient (grpc#7967) cleanup: replace dial with newclient (grpc#7970) stats/openetelemetry: refactor and make e2e test stats verification deterministic (grpc#8077) xds: introduce simple grpc transport for generic xds clients (grpc#8066) xds: generic xds client common configs re-push comments improve ServerConfig equal easwar review round 1 on documentation easwar comments on docstrings easwar comments round 4 config tests merge with previous pr xds: add lrs client and xDS client interfaces second pass to documentation language change from godoc review dfawley review 2 easwar review 1 changed to decoder struct move authorities under xds client easwar review 2 easwars review 4 ResourceWatcher done and LoadStore stop grpc based transport remove server config extension interface add byte codec dfawley review 1 send and recv tests with byte based test server change to proto based server easwar review 1 easwar review 3 xds: generic xds client ads transport channel

janardhankrishna-sai added 2 commits December 23, 2024 07:09

replace dial with newclient

7ddbe46

replace dial with newclient

71dacb1

janardhankrishna-sai and others added 18 commits December 26, 2024 11:58

updating error msg and replacing dial with newclient

88c3f0f

updating error mdg

ceb1204

revert TestFederation_UnknownAuthorityInDialTarget

6be3cf0

updating fatal msg

f6cb17c

replace dial with newclient

9f02ddd

updating error msg

7fa6e5e

Merge branch 'master' of https://github.com/janardhanvissa/grpc-go

0486355

updating error msg

aec4527

updating test

8ea1edd

updating fatal msg

c7e8c3e

updating newclient target

baec474

updating newclient target

36deff4

updating fatal msg

c58db07

updating fatal msg

973d28a

updating fatal msg

c07189f

error msg updating

1fc9c6b

updating fatal msg

d520f73

Merge branch 'grpc:master' into master

53fa9cd

arjan-bal reviewed Jan 9, 2025

View reviewed changes

Comment thread test/clientconn_state_transition_test.go Outdated

Comment thread test/gracefulstop_test.go Outdated

Comment thread xds/internal/balancer/cdsbalancer/cdsbalancer_security_test.go

Comment thread xds/internal/balancer/cdsbalancer/cdsbalancer_test.go

arjan-bal assigned janardhanvissa Jan 9, 2025

arjan-bal reviewed Jan 9, 2025

View reviewed changes

Comment thread test/xds/xds_server_serving_mode_test.go Outdated

janardhankrishna-sai added 6 commits January 9, 2025 10:40

updating newclient err msg

506fd98

Revert "updating newclient err msg"

f1ec518

This reverts commit 506fd98, reversing changes made to d520f73.

Revert "Merge branch 'master' of https://github.com/janardhanvissa/gr…

fd2860b

…pc-go" This reverts commit 0486355, reversing changes made to 7ddbe46.

Reapply "Merge branch 'master' of https://github.com/janardhanvissa/g…

56c4730

…rpc-go" This reverts commit fd2860b.

Reapply "updating newclient err msg"

5c6eb74

This reverts commit f1ec518.

Revert "updating newclient err msg"

bf780fe

This reverts commit 506fd98, reversing changes made to d520f73.

easwars removed their assignment Feb 20, 2025

updating error msg and moving cc.Connect() inside helper func

9dc0cfd

janardhanvissa requested a review from easwars February 20, 2025 23:55

janardhanvissa removed their assignment Feb 20, 2025

easwars self-assigned this Feb 21, 2025

removing explicit cc.Connect() call

7837056

easwars reviewed Feb 25, 2025

View reviewed changes

Comment thread clientconn_test.go Outdated

Comment thread clientconn_test.go Outdated

Comment thread test/xds/xds_server_serving_mode_test.go Outdated

easwars assigned janardhanvissa and unassigned easwars Feb 25, 2025

janardhankrishna-sai added 3 commits February 25, 2025 03:40

addressing review comments

5662c89

updating fatal msg

6c41a7e

updating fatal msg

e813c71

janardhanvissa removed their assignment Feb 25, 2025

janardhanvissa requested a review from easwars February 25, 2025 18:58

easwars approved these changes Feb 27, 2025

View reviewed changes

Comment thread test/xds/xds_server_serving_mode_test.go Outdated

Comment thread test/xds/xds_server_serving_mode_test.go Outdated

Comment thread examples/features/customloadbalancer/client/main.go Outdated

easwars assigned janardhanvissa Feb 27, 2025

janardhankrishna-sai added 3 commits February 27, 2025 23:16

updating error msg from NewClient() to grpc.NewClient()

093e7e4

updating error msg from NewClient() to grpc.NewClient()

cfcb91f

updating error msg

b55f656

janardhanvissa removed their assignment Feb 27, 2025

janardhanvissa requested a review from easwars February 27, 2025 23:44

easwars merged commit 52a257e into grpc:master Feb 28, 2025

janardhanvissa mentioned this pull request Mar 20, 2025

examples/features/opentelemetry: demonstrate tracing using OpenTelemetry plugin #8056

Merged

janardhanvissa added a commit to janardhanvissa/grpc-go that referenced this pull request Mar 24, 2025

cleanup: replace dial with newclient (grpc#7967)

91b6bda

janardhanvissa mentioned this pull request Apr 28, 2025

cleanup: replace dial with newclient #8196

Merged

github-actions Bot locked as resolved and limited conversation to collaborators Aug 27, 2025

Navigation Menu

Uh oh!

cleanup: replace dial with newclient - #7967

cleanup: replace dial with newclient#7967
easwars merged 71 commits into
grpc:masterfrom
janardhanvissa:replace-dial-with-newclient

janardhanvissa commented Dec 25, 2024

Uh oh!

codecov Bot commented Dec 25, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

janardhanvissa commented Feb 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

janardhanvissa commented Feb 27, 2025

Uh oh!

easwars left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

janardhanvissa commented Dec 25, 2024

Uh oh!

codecov Bot commented Dec 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

janardhanvissa commented Feb 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

janardhanvissa commented Feb 27, 2025

Uh oh!

easwars left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Dec 25, 2024 •

edited

Loading