cleanup: replace grpc.Dial with grpc.NewClient in tests #7640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7640 +/- ##
==========================================
+ Coverage 81.79% 81.81% +0.01%
==========================================
Files 361 361
Lines 27821 27821
==========================================
+ Hits 22757 22761 +4
+ Misses 3863 3858 -5
- Partials 1201 1202 +1 |
hanut19
changed the title
purnesh42H
reviewed
Sep 20, 2024
| if err != nil { | ||
| log.Fatalf("Failed to dial: %v", err) |
There was a problem hiding this comment.
failed to create new client
| @@ -847,7 +847,7 @@ func (s) TestEDS_ClusterResourceUpdates(t *testing.T) { | |||
| t.Fatalf("Timeout when waiting for old EDS watch %q to be canceled and new one %q to be registered", edsServiceName, clusterName) | |||
| } | |||
|
|
|||
| // Make an RPC, and ensure that it gets routed to second backend, | |||
There was a problem hiding this comment.
why change this? an is ok in this case
There was a problem hiding this comment.
@hanut19 please revert this
balancer/rls/picker_test.go
Outdated
| @@ -57,9 +57,9 @@ func (s) TestNoNonEmptyTargetsReturnsError(t *testing.T) { | |||
| r := startManualResolverWithConfig(t, rlsConfig) | |||
|
|
|||
| // Dial the backend. | |||
There was a problem hiding this comment.
Above comment Dial the backend should change to Create new client. Applicable everywhere
balancer/rls/picker_test.go
Outdated
| if err != nil { | ||
| t.Fatalf("grpc.Dial() failed: %v", err) | ||
| t.Fatalf("grpc.NewClient() failed: %v", err) |
There was a problem hiding this comment.
Failed to create gRPC client. Change everywhere else as well
|
@hanut19 please close the other PR |
purnesh42H
added
Area: Documentation
hanut19
force-pushed
the
replace-dial-with-newclient
branch
from
1fc951b to
04af399
Compare
dfawley
changed the title
hanut19
force-pushed
the
replace-dial-with-newclient
branch
from
04af399 to
2529133
Compare
purnesh42H
approved these changes
Sep 24, 2024
|
@dfawley for second review |
dfawley
approved these changes
Sep 24, 2024
dfawley
changed the title
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Oct 1, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address: #7049
Update tests where only direct replacement is enough to replace grpc.Dial with grpc.NewClient in test files
RELEASE NOTES: None