Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpclb: update picker synchronously on config update #7628

Closed
wants to merge 1 commit into from

Conversation

aranjans
Copy link
Contributor

#5469 recommends an audit of existing LB policies to ensure that they update their pickers synchronously upon receipt of a configuration update. grpclb does not update picker synchronously.

What does this PR do?
This PR ensures that every time configuration update is triggered, picker is updated synchronously.

RELEASE NOTES:

  • grpclb: update picker synchronously on receipt of configuration update.

@aranjans aranjans added Type: Bug Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. labels Sep 12, 2024
@aranjans aranjans added this to the 1.68 Release milestone Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.90%. Comparing base (3eb0145) to head (68cebc6).
Report is 73 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7628      +/-   ##
==========================================
+ Coverage   81.57%   81.90%   +0.32%     
==========================================
  Files         354      361       +7     
  Lines       27076    27823     +747     
==========================================
+ Hits        22088    22788     +700     
- Misses       3798     3844      +46     
- Partials     1190     1191       +1     
Files with missing lines Coverage Δ
balancer/grpclb/grpclb.go 83.49% <100.00%> (+0.81%) ⬆️

... and 91 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant