Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balancer: existing LB policies must update picker synchronously #5469

Open
8 of 14 tasks
easwars opened this issue Jun 24, 2022 · 3 comments
Open
8 of 14 tasks

balancer: existing LB policies must update picker synchronously #5469

easwars opened this issue Jun 24, 2022 · 3 comments
Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. fixit P3 Type: Bug

Comments

@easwars
Copy link
Contributor

easwars commented Jun 24, 2022

#5211 talks about delaying picker updates in LB policies which have child policies, until the configs have been propagated to all the children. It also talks about auditing existing code to ensure that existing LB policy implementations update their pickers synchronously upon receipt of a config update.

We will use this issue to ensure that we have audited all existing LB policy implementations, and update docs to indicate the same.

@dfawley dfawley added the P1 label Jun 28, 2022
@easwars easwars added the fixit label Nov 28, 2022
@arvindbr8 arvindbr8 added P1 P3 and removed P1 labels Feb 28, 2024
@aranjans
Copy link
Contributor

aranjans commented May 2, 2024

@easwars I see ringhash_experimental policy already has picker update in sync with the config update here and similarly i see the same for many other lb policies. Am I missing something here?

@purnesh42H purnesh42H assigned purnesh42H and unassigned purnesh42H May 2, 2024
@aranjans aranjans self-assigned this May 2, 2024
@easwars
Copy link
Contributor Author

easwars commented May 2, 2024

@easwars I see ringhash_experimental policy already has picker update in sync with the config update here and similarly i see the same for many other lb policies. Am I missing something here?

Yes, you are right about the ringhash LB policy. I updated the PR description to reflect this.

The same needs to be done for other policies in the list and once confirmed, the PR description needs to be updated accordingly. Thanks.

@aranjans
Copy link
Contributor

aranjans commented May 2, 2024

@easwars What about outlier_detection_experimental here, i believe its already done for outlier_detection_experimental as well as many others already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. fixit P3 Type: Bug
Projects
None yet
Development

No branches or pull requests

5 participants