rls: update picker synchronously on configuration update #7412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aranjans
changed the title
aranjans
force-pushed
the
aranjans_7212_1
branch
from
33c5214
to
352d865
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7412 +/- ##
==========================================
- Coverage 81.96% 81.82% -0.15%
==========================================
Files 360 360
Lines 27533 27533
==========================================
- Hits 22568 22529 -39
- Misses 3780 3799 +19
- Partials 1185 1205 +20
|
aranjans
force-pushed
the
aranjans_7212_1
branch
from
352d865
to
b500c57
Compare
aranjans
force-pushed
the
aranjans_7212_1
branch
from
b500c57
to
c2046f5
Compare
aranjans
force-pushed
the
aranjans_7212_1
branch
from
c2046f5
to
e9997a0
Compare
arjan-bal
reviewed
Jul 17, 2024
aranjans
force-pushed
the
aranjans_7212_1
branch
from
0aff932
to
b2f4155
Compare
|
@arjan-bal I have updated the PR and referenced your comments in the code change. |
arjan-bal
reviewed
Jul 18, 2024
|
@arjan-bal thAnks for your review, I have updated the PR with your suggestions. |
easwars
reviewed
Aug 7, 2024
aranjans
force-pushed
the
aranjans_7212_1
branch
from
4e14220
to
6c27bbd
Compare
easwars
reviewed
Aug 14, 2024
easwars
reviewed
Aug 14, 2024
easwars
approved these changes
Aug 15, 2024
easwars
approved these changes
Aug 16, 2024
infovivek2020
pushed a commit
to infovivek2020/grpc-go
that referenced
this pull request
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7212.
Problem
#5469 recommends an audit of existing LB policies to ensure that they update their pickers synchronously upon receipt of a configuration update. RLS lb policy do updates the picker synchronously but misses out in one single corner case when there is a config change in cache size, where we need to send picker update in case any cache entry with valid backoff was evicted.
What does this PR do?
This PR handles that corner cases and make sure it updates the picker in all of the cases synchronously with config update of RLS lb policy.
RELEASE NOTES: