Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop/xds: Increase go log verbosity to 99 so that EDS is logged (v1.59.x backport) #6881

Merged

Merge branch 'v1.59.x' into backport-1.59-psm-interop-verbosity

6403089
Select commit
Loading
Failed to load commit list.
Merged

interop/xds: Increase go log verbosity to 99 so that EDS is logged (v1.59.x backport) #6881

Merge branch 'v1.59.x' into backport-1.59-psm-interop-verbosity
6403089
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed Jun 17, 2024 in 4s

2/3 Fail(s): LABEL, MILESTONE

Status: FAIL

    Here are some stats of the run:
    3 validations were ran.
    1 PASSED
    2 FAILED

Details

❌ Validator: LABEL

  • label does not include "^Type:"
    Input :
    Settings : {"must_include":{"regex":"^Type:"}}

✔️ Validator: DESCRIPTION

  • ✔️ description must include '^RELEASE NOTES:\s([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\n(*|-)\s.+)$'**
    Input : Backport of #6860 to v1.59.x.

gRPC-go versions v1.54.x and later don't log ADS responses anymore. This makes it hard to debug without being able to see EDS resources. Logging behavior was changed by #5992.

This PR updates XdsTestServer/XdsTestClient Docker images so that GRPC_GO_LOG_VERBOSITY_LEVEL is increased from 2 to 99.

RELEASE NOTES: N/A
Settings : {"must_include":{"regex":"^RELEASE NOTES:\\s*([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\\n(\\*|-)\\s*.+)$","regex_flag":"m"}}

❌ Validator: MILESTONE

  • milestone does not include "Release$"
    Input :
    Settings : {"must_include":{"regex":"Release$"}}