interop/xds: Increase go log verbosity to 99 so that EDS is logged #6860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gRPC-go versions v1.54.x and later don't log ADS responses anymore. This makes it hard to debug without being able to see EDS resources. Logging behavior was changed by grpc#5992. This PR updates XdsTestServer/XdsTestClient Docker images so that GRPC_GO_LOG_VERBOSITY_LEVEL is increased from `2` to `99`. RELEASE NOTES: N/A
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6860 +/- ##
==========================================
+ Coverage 83.69% 83.71% +0.02%
==========================================
Files 286 286
Lines 30792 30792
==========================================
+ Hits 25770 25779 +9
+ Misses 3961 3955 -6
+ Partials 1061 1058 -3 |
|
Confirmed v1.53.x still logs ADS, and v1.54.x doesn't. v1.53.x v1.54.x |
|
Allright, we're seeing ADS responses now: |
dfawley
approved these changes
Dec 16, 2023
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc-go
that referenced
this pull request
Dec 18, 2023
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc-go
that referenced
this pull request
Dec 18, 2023
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc-go
that referenced
this pull request
Dec 18, 2023
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc-go
that referenced
this pull request
Dec 18, 2023
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc-go
that referenced
this pull request
Dec 18, 2023
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc-go
that referenced
this pull request
Dec 18, 2023
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc-go
that referenced
this pull request
Dec 18, 2023
This was referenced Dec 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC-go versions v1.54.x and later don't log ADS responses anymore. This makes it hard to debug without being able to see EDS resources. Logging behavior was changed by #5992.
This PR updates XdsTestServer/XdsTestClient Docker images so that GRPC_GO_LOG_VERBOSITY_LEVEL is increased from
2to99.RELEASE NOTES: N/A