xds/federation: support new bootstrap fields and protect them by an env var #4936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
reviewed
Nov 4, 2021
| } | ||
| case "client_default_listener_resource_name_template": | ||
| if !env.FederationSupport { | ||
| return nil, fmt.Errorf("xds: bootstrap field %v is not support when Federation is disabled", k) |
Contributor
There was a problem hiding this comment.
We have so far handled unknown fields by ignoring them (and we recently added code to log them). Why do you want to return an error here instead?
Contributor
Author
There was a problem hiding this comment.
Should just log the error. Fixed.
…fields and protect them by an env var
menghanl
force-pushed
the
federation_bootstrap_env_var
branch
from
ad64330 to
1fd47a7
Compare
easwars
approved these changes
Nov 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4892
RELEASE NOTES: N/A