-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc-gen-go-grpc: add requirement of embedding UnimplementedServer in services #3657
Changes from 6 commits
fc3249e
191ebb6
c14716d
48faafb
5c8b3ca
3714849
61f94de
ec61e33
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# protoc-gen-go-grpc | ||
|
||
This tool generates Go language bindings of `service`s in protobuf definition | ||
files for gRPC. For usage information, please see our [quick start | ||
guide](https://grpc.io/docs/languages/go/quickstart/). | ||
|
||
By default, to register services using the methods generated by this tool, the | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move this to a separate section? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
services must embed the corresponding `Unimplemented<ServiceName>Server`. This | ||
is a behavior change from the grpc code generator previously included with | ||
`protoc-gen-go`. To restore this behavior, set the option | ||
`requireUnimplementedServers=false`. E.g.: | ||
|
||
``` | ||
protoc --go-grpc_out=requireUnimplementedServers=false[,other options...]:. \ | ||
``` |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick start doesn't have examples for using this plugin (yet?)
Even if it does, it would be helpful to have a copy-paste ready command here?
Or point to https://github.com/grpc/grpc-go/blob/master/regenerate.sh#L60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation is very much a work in progress. Let's make incremental progress on it until we eventually release the tool at 1.0.