Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoc-gen-go-grpc: add requirement of embedding UnimplementedServer in services #3657

Merged
merged 8 commits into from
Jun 4, 2020
Merged

protoc-gen-go-grpc: add requirement of embedding UnimplementedServer in services #3657

merged 8 commits into from
Jun 4, 2020

Commits on Jun 1, 2020

  1. protoc-gen-go-grpc: add requirement of embedding Unimplemented___Serv… 

    …er for services
    @dfawley
    dfawley committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    fc3249e View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. remove the _

    @dfawley
    dfawley committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    191ebb6 View commit details
    Browse the repository at this point in the history

  2. regenerate

    @dfawley
    dfawley committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    c14716d View commit details
    Browse the repository at this point in the history

  3. mustEmbed

    @dfawley
    dfawley committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    48faafb View commit details
    Browse the repository at this point in the history

  4. don't require Unimplemented to be embedded in our .pb.gos, since this… 

    … would be an API change
    @dfawley
    dfawley committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    5c8b3ca View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. tweak comments produced in generated code; add README.md

    @dfawley
    dfawley committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    3714849 View commit details
    Browse the repository at this point in the history

  2. add 'not recommended' note

    @dfawley
    dfawley committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    61f94de View commit details
    Browse the repository at this point in the history

  3. future proof

    @dfawley
    dfawley committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    ec61e33 View commit details
    Browse the repository at this point in the history