Example code and documentation on how to mock gRPC services #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rpc-go into mmukhi_gomock_example
MakMukhi
changed the title
menghanl
reviewed
Dec 14, 2016
| "testing" | ||
|
|
||
| "github.com/golang/mock/gomock" | ||
| proto "github.com/golang/protobuf/proto" |
There was a problem hiding this comment.
The renaming is unnecessary.
| @@ -0,0 +1,2 @@ | |||
| mockgen google.golang.org/grpc/examples/helloworld/helloworld GreeterClient > mock_helloworld/hw_mock.go | |||
| gofmt -w mock_helloworld/hw_mock.go | |||
There was a problem hiding this comment.
Is this file necessary? We already have the commands in the md file.
(And why do we need the gofmt here?
| "github.com/golang/mock/gomock" | ||
| proto "github.com/golang/protobuf/proto" | ||
| "golang.org/x/net/context" | ||
| "google.golang.org/grpc/examples/helloworld/helloworld" |
There was a problem hiding this comment.
Add alias for this import because it is a proto.
| } | ||
|
|
||
| func TestSayHello(t *testing.T) { | ||
| ctrl := gomock.NewController(t) |
There was a problem hiding this comment.
Wrap this in a function createMock returning a mocking client?
| @@ -0,0 +1,121 @@ | |||
| # Mocking Service for gRPC | |||
|
|
|||
| Example code: examples/helloworld/mock | |||
There was a problem hiding this comment.
Add a link here to the folder.
And a one line file summary?
| mockGreeterClient.EXPECT().SayHello( | ||
| gomock.Any(), // expect any value for first parameter | ||
| gomock.Any(), // expect any value for second parameter | ||
| ).Return(&helloworld.HelloReply{Message: “Mocked RPC”},nil) |
sailat
approved these changes
Feb 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.