Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use collectionFormat multi for query params of repeated fields (#902)" #907

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

johanbrandhorst
Copy link
Collaborator

This reverts commit 2b6cab6. It was found
to have introduced a swagger spec violation, see #906.

#902)"

This reverts commit 2b6cab6. It was found
to have introduced a swagger spec violation, see #906.
@johanbrandhorst
Copy link
Collaborator Author

I think we'll close #906 and reopen #756 instead.

@codecov-io
Copy link

Codecov Report

Merging #907 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
- Coverage   53.54%   53.52%   -0.03%     
==========================================
  Files          40       40              
  Lines        3961     3959       -2     
==========================================
- Hits         2121     2119       -2     
  Misses       1642     1642              
  Partials      198      198
Impacted Files Coverage Δ
protoc-gen-swagger/genswagger/types.go 19.04% <ø> (ø) ⬆️
protoc-gen-swagger/genswagger/template.go 56.33% <100%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aca14d...d294104. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit 8994a11 into master Mar 13, 2019
@mmarod
Copy link

mmarod commented Mar 13, 2019

Thanks @johanbrandhorst for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants