Use collectionFormat multi for query params of repeated fields

[bmperrea]

Solves #756 . Also formats protoc-gen-swagger/genswagger/template_test.go according to go fmt.

[achew22]

Looks like really great work! FYI, I think the way to fix the generate CI failure is to run

docker run -v $(pwd):/go/src/github.com/grpc-ecosystem/grpc-gateway --rm jfbrandhorst/grpc-gateway-build-env:1.12 \
    /bin/bash -c 'cd /go/src/github.com/grpc-ecosystem/grpc-gateway && \
        make realclean && \
        make examples SWAGGER_CODEGEN="${SWAGGER_CODEGEN}"'

which will regenerate the examples. I'm really looking forward to this!

[bmperrea]

Thanks @achew22 ! A docker run to generate these files will be great - I was having trouble figuring out how to get the right version of swagger-codegen (2.2.2).

When I run the command you posted I get

can't load package: package github.com/golang/protobuf/protoc-gen-go: cannot find package "github.com/golang/protobuf/protoc-gen-go" in any of:
	/usr/local/go/src/github.com/golang/protobuf/protoc-gen-go (from $GOROOT)
	/go/src/github.com/golang/protobuf/protoc-gen-go (from $GOPATH)

I have protoc-gen-go installed on my local, but I guess the docker run is missing a dependency.

[johanbrandhorst]

That's very strange, this is the command run by CI when generating the diff that's failing. Are you sure you ran the command correctly?

[johanbrandhorst]

Ah, there is a problem with the mount path in Andrews link. Try this:

docker run -v $(pwd):/src/grpc-gateway --rm jfbrandhorst/grpc-gateway-build-env:1.12 \ /bin/bash -c 'cd /src/grpc-gateway && \         make realclean && \         make examples SWAGGER_CODEGEN="${SWAGGER_CODEGEN}"'

[johanbrandhorst]

FYI the source of truth for this command is CONTRIBUTING.md

[johanbrandhorst]

(Andrews command is how we used to run it before we switched to go modules).

[codecov-io]

Codecov Report

Merging #902 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #902      +/-   ##
==========================================
+ Coverage   53.59%   53.61%   +0.02%     
==========================================
  Files          39       39              
  Lines        3935     3937       +2     
==========================================
+ Hits         2109     2111       +2     
  Misses       1629     1629              
  Partials      197      197

Impacted Files	Coverage Δ
protoc-gen-swagger/genswagger/types.go	19.04% <ø> (ø)	⬆️
protoc-gen-swagger/genswagger/template.go	56.42% <100%> (+0.08%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb0d96...30a13e5. Read the comment docs.

[johanbrandhorst]

Note to self: tests are a bit flaky, we should consider increasing the wait for the server to start up.

[johanbrandhorst]

Thanks for your contribution!

[johanbrandhorst]

We should make a release with this new functionality

[mmarod]

I believe that this may have inadvertently broken spec...

  "definitions": {
    "Foo": {
      "type": "object",
      "properties": {
        "foo": {
          "type": "array",
          "items": {
            "$ref": "#/definitions/Bar"
          },
          "description": "foo",
          "collectionFormat": "multi"
        }
...

This spits out the following error when I run swagger generate server

- definitions.Foo.properties.foo.collectionFormat in body is a forbidden property

[johanbrandhorst]

Thanks for your report @mmarod, could you raise an issue please? That is unfortunate.

[johanbrandhorst]

My immediate thought is that is happens when we have repeated fields in the body of a request instead of in the query parameters of the URL. Might just need a little extra logic.

[johanbrandhorst]

I raised #906

[gomisc]

I have same trouble when do swagger spec validation...
Fix please guys. Thanks

Look here
OAI/OpenAPI-Specification#419 (comment)

[johanbrandhorst]

Since that makes two of you that have spoken up I'm going to revert this until we can fix #906 at the same time.

[johanbrandhorst]

I've reverted the change in master and will make another release.