gen-swagger: use GetJsonName for struct member names #681
Conversation
|
Hey @utrack, thanks for sending in a PR! This is definitely a change I would like to make. The swagger generator is objectively wrong. Unfortunately it is wrong in a way that is paired with our default marshaller. In order to make this change we would have to change the default marshaller, which is a kind of big change. What would you think about adding this as a flag controlled argument to the swagger generator? That would let you continue forward while I try to figure out a path to removing the bad marshaller. |
|
Oh dang, I just noticed I've already filled #375 :) I see that the new flag should be added via common registry - it would be confusing for the flag to work w/ I'll maintain my fork w/ What's the issue related to the marshaller replacement, if there's any? I might be able to help with that. |
This fork uses the correct JSON names as specified by the Protobuf to JSON mapping (https://developers.google.com/protocol-buffers/docs/proto3#json). This is needed until grpc-ecosystem/grpc-gateway#681 has been merged.
|
This is already being considered in #546 |
This PR fixed Swagger definition.
Currently
protoc-gen-swaggeruses.GetName()to get a field name.It's wrong, since proto field
snake_case's generated name injsontag issnakeCase- however, generated swagger still hassnake_casein the definition..GetJsonName()returns field name in the right case and form.