Massive breaking changes in preparation for 2.0 #546
Conversation
achew22
force-pushed
the
upgrade_swagger_codegen
branch
2 times, most recently
from
5aa0d42
to
b1d75c2
Compare
|
may want to update # 5 https://github.com/grpc-ecosystem/grpc-gateway/blob/master/CONTRIBUTING.md also |
achew22
force-pushed
the
upgrade_swagger_codegen
branch
from
b1d75c2
to
231b75f
Compare
One of the recurring themes of this project has been trouble around the
default marshaller. This change modifies it to be more what people
expect when they first start the project.
1. It emits the proto3 json style version of field names instead of the
field name as it appeared in the .proto file.
2. It emits zero values for fields. This means that if you have a field
that is unset it will now have a value unlike before.
Upgrade to swagger-codegen 2.4.0
Also fix a regex-o in .travis.yml. + needed to be escaped.
Fixes: grpc-ecosystem#540, grpc-ecosystem#375, grpc-ecosystem#254, grpc-ecosystem#233
achew22
force-pushed
the
upgrade_swagger_codegen
branch
from
231b75f
to
3a9bf3a
Compare
achew22
changed the title
|
This seems to have suffered some bitrot, which is unfortunate for a large change like this as it'll be a pain to keep rebasing it. |
|
Other things I'd like for 2.0: Output errors in the same format as the gRPC-Go |
|
Another one: Adopt the correct behaviour for custom verbs (see #224 (comment)). |
|
Please rebase on master for new CI functionality. 😬 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
We'd love to have help getting this in for v2, though I'm not sure the original author will have the time. |
This PR turned out to be an absolutely gigantic... thing. Since I'm making breaking changes why not break all the things.
Things I broke:
Obviously this can't go in until swagger 2.4 is released, but we have a backlog of significant breaking changes that would improve the quality of the service dramatically. My plan is to cut one last 1.X branch release then merge merge merge and cut a 2.0
TODO