Add runtime.WithForwardResponseOption #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure on the Travis build failure - advise? |
|
Tests passing on travis now |
|
Ping :) |
Added http error code and error status for responseStreamChunk error
|
Hey @yugui, what do you think of this PR? I need this ASAP, can we pursue this? |
|
@peter-edge sorry for being late. I'll take a look. |
| if _, err = w.Write(buf); err != nil { | ||
| glog.Errorf("Failed to write response: %v", err) | ||
| } | ||
| } | ||
|
|
||
| func handleForwardResponseOptions(ctx context.Context, w http.ResponseWriter, resp proto.Message, opts []func(context.Context, http.ResponseWriter, proto.Message) error) error { | ||
| if opts == nil || len(opts) == 0 { |
|
Could you resolve the merge conflict? |
|
merge conflict fixed |
yugui
added a commit
that referenced
this pull request
Sep 28, 2015
Add runtime.WithForwardResponseOption
ithinker1991
pushed a commit
to tronprotocol/grpc-gateway
that referenced
this pull request
May 27, 2018
…tNextMaintenanceTime_api Feature/add get next maintenance time api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one may be a bit more work back and forth. The idea is that sometimes, you want to be able to modify values prior to sending the response over the wire. An example of this is https://go.pedge.io/dockervolume - I'd like to be able to modify the VolumeDriver interface to be a Protocol Buffers interface, and then use grpc-gateway to handle the API calls, but to do so, I need to be able to set a custom content type for API versioning with Docker.
This change should be backwards compatible. It also includes the changes from #52 so that the tests pass.