Added http error code and error status for responseStreamChunk error #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,6 +17,13 @@ type responseStreamChunk struct { | |||
| Error string `json:"error,omitempty"` | |||
| } | |||
|
|
|||
| type responseStreamError struct { | |||
| GrpcCode int `json:"grcp_code, omitempty"` | |||
| HttpCode int `json:"http_code, omitempty"` | |||
There was a problem hiding this comment.
Golint error. Should be HTTPCode.
|
I like the direction, but please fix some errors.
|
|
I have fixed the mentioned issues. Could you please have an other look? |
|
LGTM. Thank you for your contribution. |
yugui
added a commit
that referenced
this pull request
Sep 25, 2015
Added http error code and error status for responseStreamChunk error
ithinker1991
pushed a commit
to tronprotocol/grpc-gateway
that referenced
this pull request
Jun 18, 2018
Add total net api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #58