Repository navigation
Bump dependencies - #51
Conversation
Co-authored-by: fflorent <371705+fflorent@users.noreply.github.com>
Co-authored-by: fflorent <371705+fflorent@users.noreply.github.com>
…searches PATH Co-authored-by: fflorent <371705+fflorent@users.noreply.github.com>
This will solve some security vulnerabilities in dependencies
| "chai": "^4.5.0", | ||
| "chai-as-promised": "^7.1.2", | ||
| "fs-extra": "^11.3.4", | ||
| "mocha": "^11.7.5", |
There was a problem hiding this comment.
I wonder if for mocha, chai-as-promised and chai it would not be possible and better to make them peer dependencies (but it might have some drawbacks too, not 100% sure of myself)
|
Thank you @fflorent! How do you feel about removing Also, would you like to try upgrading tslint to latest? It seems responsible for some For package-lock, it may be good to delete it and recreate by reinstalling from scratch. I suspect there will be no difference to build/lint/test (and package-lock does not affect packages that depend on |
|
@dsagal Makes sense, thanks!
tslint is deprecated in favor of eslint: https://www.npmjs.com/package/tslint I take a look at this package to see whether I can migrate easily: https://www.npmjs.com/package/tslint-to-eslint-config |
|
Yeah, I didn't want to create more work for you. Feel free to ruthlessly upgrade to the same eslint config as grist-core (or keep as tslint). There is almost never any changes to this package, so there is not going to be much debate on code styles. |
|
@dsagal Done. Also there seem to remain some |
|
Actually version 0.3.4 was already the published one, but not merged into master. I bumped this to 0.3.5 and published to npm. |
## Context Selenium is a bit outdated ## Proposed solution Bump mocha-webdriver to 0.3.5. See this PR: gristlabs/mocha-webdriver#51 ## Related issues <!-- If suggesting a new feature or change, please discuss it in an issue first --> <!-- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!-- If this does not solve entirely the issue, make also a checklist of what is done or not: --> ## Has this been tested? <!-- Put an `x` in the box that applies: --> - [ ] 👍 yes, I added tests to the test suite - [ ] 💭 no, because this PR is a draft and still needs work - [x] 🙅 no, because this is not relevant here - [ ] 🙋 no, because I need help <!-- Detail how we can help you -->
Bumps the dependencies, especially selenium.
This action has been made by Copilot.
What I have done:
package-lock.jsonandyarn.lockfiles have been generated myself.npm run build,yarn build,yarn testandnpm test, everything works as expected (using nodev24.14.0)npm audit fixto fix some vulnerabilities in dependencies, and removedyarn.lockfile to regenerate it frompackage-lock.jsonusingyarn import(soyarn.lockalso benefits from the changes brought bynpm audit fix)