Skip to content

Bump dependencies - #51

Merged
dsagal merged 10 commits into
gristlabs:masterfrom
fflorent:bump-dependencies
Mar 19, 2026
Merged

dsagal merged 10 commits into
gristlabs:masterfrom
fflorent:bump-dependencies

Conversation

@fflorent

@fflorent fflorent commented Mar 19, 2026 •

Copy link
Copy Markdown
Contributor

Bumps the dependencies, especially selenium.

This action has been made by Copilot.

What I have done:

  1. Reverted any source code modification (the one proposed were useless);
  2. package-lock.json and yarn.lock files have been generated myself.
  3. Run locally npm run build, yarn build, yarn test and npm test, everything works as expected (using node v24.14.0)
  4. Also I ran npm audit fix to fix some vulnerabilities in dependencies, and removed yarn.lock file to regenerate it from package-lock.json using yarn import (so yarn.lock also benefits from the changes brought by npm audit fix)

Copilot AI and others added 8 commits March 19, 2026 09:47
Co-authored-by: fflorent <371705+fflorent@users.noreply.github.com>
Co-authored-by: fflorent <371705+fflorent@users.noreply.github.com>
…searches PATH

Co-authored-by: fflorent <371705+fflorent@users.noreply.github.com>
This will solve some security vulnerabilities in dependencies
Comment thread package.json
"chai": "^4.5.0",
"chai-as-promised": "^7.1.2",
"fs-extra": "^11.3.4",
"mocha": "^11.7.5",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if for mocha, chai-as-promised and chai it would not be possible and better to make them peer dependencies (but it might have some drawbacks too, not 100% sure of myself)

@dsagal

dsagal commented Mar 19, 2026

Copy link
Copy Markdown
Member

Thank you @fflorent! How do you feel about removing yarn.lock and dropping all references to yarn? All commands use npm, and npm seems sufficient for this repo. No need to maintain two approaches.

Also, would you like to try upgrading tslint to latest? It seems responsible for some npm audit warnings.

For package-lock, it may be good to delete it and recreate by reinstalling from scratch. I suspect there will be no difference to build/lint/test (and package-lock does not affect packages that depend on mocha-webdriver), and there is a chance it would fix some other npm audit warnings.

@fflorent

Copy link
Copy Markdown
Contributor Author

@dsagal Makes sense, thanks!

Also, would you like to try upgrading tslint to latest? It seems responsible for some npm audit warnings.

tslint is deprecated in favor of eslint: https://www.npmjs.com/package/tslint

I take a look at this package to see whether I can migrate easily: https://www.npmjs.com/package/tslint-to-eslint-config

@dsagal

dsagal commented Mar 19, 2026 •

Copy link
Copy Markdown
Member

Yeah, I didn't want to create more work for you. Feel free to ruthlessly upgrade to the same eslint config as grist-core (or keep as tslint). There is almost never any changes to this package, so there is not going to be much debate on code styles.

@fflorent

Copy link
Copy Markdown
Contributor Author

@dsagal Done. Also there seem to remain some npm audit warnings that will be fixed with the next version of mocha:
mochajs/mocha#5589

@dsagal dsagal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dsagal
dsagal merged commit 2e6d6c4 into gristlabs:master Mar 19, 2026
@github-project-automation github-project-automation Bot moved this from Needs feedback to Done in French administration Board Mar 19, 2026
@dsagal

dsagal commented Mar 19, 2026

Copy link
Copy Markdown
Member

Actually version 0.3.4 was already the published one, but not merged into master. I bumped this to 0.3.5 and published to npm.

dsagal pushed a commit to gristlabs/grist-core that referenced this pull request Mar 25, 2026
## Context

Selenium is a bit outdated

## Proposed solution

Bump mocha-webdriver to 0.3.5. See this PR:
gristlabs/mocha-webdriver#51

## Related issues

<!-- If suggesting a new feature or change, please discuss it in an
issue first -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!-- If this does not solve entirely the issue, make also a checklist of
what is done or not: -->

## Has this been tested?

<!-- Put an `x` in the box that applies: -->

- [ ] 👍 yes, I added tests to the test suite
- [ ] 💭 no, because this PR is a draft and still needs work
- [x] 🙅 no, because this is not relevant here
- [ ] 🙋 no, because I need help <!-- Detail how we can help you -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants