Skip to content

Bump mocha-webdriver to 0.3.5 - #2198

Merged
dsagal merged 2 commits into
gristlabs:mainfrom
gristgouv:bump-mocha-webdriver-0.3.5
Mar 25, 2026
Merged

dsagal merged 2 commits into
gristlabs:mainfrom
gristgouv:bump-mocha-webdriver-0.3.5

Conversation

@fflorent

Copy link
Copy Markdown
Collaborator

Context

Selenium is a bit outdated

Proposed solution

Bump mocha-webdriver to 0.3.5. See this PR:
gristlabs/mocha-webdriver#51

Related issues

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this is not relevant here
  • 🙋 no, because I need help

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the test automation stack by bumping mocha-webdriver (and the Selenium/webdriver-related dependency chain it pulls in), with a few small TypeScript test adjustments to match updated typings/APIs.

Changes:

  • Bump mocha-webdriver to 0.3.5, bringing in newer selenium-webdriver and related transitive updates.
  • Update chai / chai-as-promised and related @types/* versions.
  • Fix TypeScript test compilation issues introduced by updated typings (e.g., mocha-webdriver chromium types, stricter object typings in assertions).

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Updates mocha-webdriver, chai, chai-as-promised, and several @types/* packages.
yarn.lock Refreshes resolved dependency graph for the bumped packages (notably selenium/mocha/chai related).
test/nbrowser/Themes.ts Updates mocha-webdriver imports/types to use the newer chromium typing surface.
test/gen-server/lib/homedb/UsersManager.ts Adjusts assertion object typing (UserOptions) to satisfy stricter TS checks.
test/gen-server/ApiServerAccess.ts Adds explicit chai.assert typing for TS compatibility.
test/gen-server/ApiServer.ts Adds explicit chai.assert typing for TS compatibility.
test/common/airtable/AirtableSchemaImporter.ts Casts assertion object to ColumnImportSchema to satisfy stricter TS checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json Resolved
@fflorent fflorent moved this from Needs Internal Feedback to Needs feedback in French administration Board Mar 23, 2026
@fflorent
fflorent requested a review from dsagal March 23, 2026 16:23
@fflorent
fflorent force-pushed the bump-mocha-webdriver-0.3.5 branch from 9d3d12d to ffeee7e Compare March 24, 2026 14:51
@dsagal
dsagal merged commit 17e34cb into gristlabs:main Mar 25, 2026
15 checks passed
@github-project-automation github-project-automation Bot moved this from Needs feedback to Done in French administration Board Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants