Repository navigation
Bump mocha-webdriver to 0.3.5 - #2198
Merged
Merged
Conversation
fflorent
force-pushed
the
bump-mocha-webdriver-0.3.5
branch
from
March 23, 2026 15:57
9477520 to
3b9d600
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the test automation stack by bumping mocha-webdriver (and the Selenium/webdriver-related dependency chain it pulls in), with a few small TypeScript test adjustments to match updated typings/APIs.
Changes:
- Bump
mocha-webdriverto0.3.5, bringing in newerselenium-webdriverand related transitive updates. - Update
chai/chai-as-promisedand related@types/*versions. - Fix TypeScript test compilation issues introduced by updated typings (e.g., mocha-webdriver chromium types, stricter object typings in assertions).
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
package.json |
Updates mocha-webdriver, chai, chai-as-promised, and several @types/* packages. |
yarn.lock |
Refreshes resolved dependency graph for the bumped packages (notably selenium/mocha/chai related). |
test/nbrowser/Themes.ts |
Updates mocha-webdriver imports/types to use the newer chromium typing surface. |
test/gen-server/lib/homedb/UsersManager.ts |
Adjusts assertion object typing (UserOptions) to satisfy stricter TS checks. |
test/gen-server/ApiServerAccess.ts |
Adds explicit chai.assert typing for TS compatibility. |
test/gen-server/ApiServer.ts |
Adds explicit chai.assert typing for TS compatibility. |
test/common/airtable/AirtableSchemaImporter.ts |
Casts assertion object to ColumnImportSchema to satisfy stricter TS checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fflorent
force-pushed
the
bump-mocha-webdriver-0.3.5
branch
from
March 24, 2026 14:51
9d3d12d to
ffeee7e
Compare
dsagal
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Selenium is a bit outdated
Proposed solution
Bump mocha-webdriver to 0.3.5. See this PR:
gristlabs/mocha-webdriver#51
Related issues
Has this been tested?