-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor python-gvm API] Step 2: Detach Trashcan, Authentication, Version, (feed) #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
=======================================
Coverage 97.71% 97.72%
=======================================
Files 50 54 +4
Lines 3807 3822 +15
Branches 926 926
=======================================
+ Hits 3720 3735 +15
Misses 73 73
Partials 14 14
Continue to review full report at Codecov.
|
…ns calls to VersionsMixin
y0urself
changed the title
[Refactor python-gvm API] Step 2: Detach Trashcan, Authentication, Base
[Refactor python-gvm API] Step 2: Detach Trashcan, Authentication, Version, (feed)
May 20, 2021
bjoernricks
requested changes
May 21, 2021
bjoernricks
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
get_setting(s)
->get_user_setting(s)
,modify_setting
->modify_user_setting
. #472TrashcanMixin
. #472AuthenticationMixin
. #472VersionsMixin
. #472FeedMixin
. #468 #472sync_feed
,sync_scap
, andsync_cert
calls. #472Why:
How:
Checklist: