Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor python-gvm API] Step 2: Detach Trashcan, Authentication, Version, (feed) #472

Merged
merged 16 commits into from
May 21, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented May 20, 2021

What:

  • API changes: get_setting(s) -> get_user_setting(s), modify_setting -> modify_user_setting. #472
  • Detached the Trashcan API calls from the GMP class into a new TrashcanMixin. #472
  • Detached the Authentication API calls from the GMP class into a new AuthenticationMixin. #472
  • Detached the Version API calls from the GMP class into a new VersionsMixin. #472
  • Detached the rest of the Feeds API calls from the GMP class into a new FeedMixin. #468 #472
  • Removed sync_feed, sync_scap, and sync_cert calls. #472

Why:

How:

Checklist:

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #472 (9332cb2) into master (48952fa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #472   +/-   ##
=======================================
  Coverage   97.71%   97.72%           
=======================================
  Files          50       54    +4     
  Lines        3807     3822   +15     
  Branches      926      926           
=======================================
+ Hits         3720     3735   +15     
  Misses         73       73           
  Partials       14       14           
Impacted Files Coverage Δ
gvm/protocols/gmpv208/gmpv208.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/system/authentication.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/system/feed.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/system/trashcan.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/system/user_settings.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/system/version.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv214/system/version.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48952fa...9332cb2. Read the comment docs.

@y0urself y0urself changed the title [Refactor python-gvm API] Step 2: Detach Trashcan, Authentication, Base [Refactor python-gvm API] Step 2: Detach Trashcan, Authentication, Version, (feed) May 20, 2021
@y0urself y0urself marked this pull request as ready for review May 21, 2021 06:43
@y0urself y0urself requested a review from a team as a code owner May 21, 2021 06:43
@y0urself y0urself enabled auto-merge May 21, 2021 06:45
gvm/protocols/gmpv208/system/feed.py Outdated Show resolved Hide resolved
@y0urself y0urself merged commit b1214cd into greenbone:master May 21, 2021
@y0urself y0urself deleted the detach-base branch October 9, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants