Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor python-gvm API] Step 2: Detach Aggregates, Tags and Feeds #468

Merged
merged 13 commits into from
May 20, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented May 19, 2021

What:

Why:

How:

Checklist:

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #468 (38ea9db) into master (9be8a78) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #468      +/-   ##
==========================================
+ Coverage   97.75%   97.91%   +0.15%     
==========================================
  Files          41       44       +3     
  Lines        3790     3791       +1     
==========================================
+ Hits         3705     3712       +7     
+ Misses         85       79       -6     
Impacted Files Coverage Δ
gvm/protocols/gmpv208/gmpv208.py 98.98% <ø> (+0.64%) ⬆️
gvm/protocols/gmpv208/types.py 100.00% <ø> (ø)
gvm/protocols/gmpv214/types.py 100.00% <ø> (ø)
gvm/protocols/gmpv208/entities/aggregates.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/entities/feeds.py 100.00% <100.00%> (ø)
gvm/protocols/gmpv208/entities/tags.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9be8a78...38ea9db. Read the comment docs.

@y0urself y0urself marked this pull request as ready for review May 19, 2021 16:48
@y0urself y0urself requested a review from a team as a code owner May 19, 2021 16:48
@y0urself y0urself enabled auto-merge May 19, 2021 16:49
@y0urself y0urself merged commit d15ae40 into greenbone:master May 20, 2021
@y0urself y0urself deleted the detach-agg-tags-feed branch October 9, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants