Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor python-gvm API] Step 2: Detach Alerts #458

Merged
merged 14 commits into from
May 17, 2021
Merged

[Refactor python-gvm API] Step 2: Detach Alerts #458

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2dc5bba
Moved Alert related calls and types to seperate file
y0urself May 12, 2021
5f2022c
Add the Mixin and Types to 208 and 214
y0urself May 13, 2021
42ae16a
Moved alert tests to dir
y0urself May 14, 2021
b9b32af
Add the new test cases
y0urself May 14, 2021
81277d1
Remove the alert test cases from old structure
y0urself May 14, 2021
e615a36
Improve get_from_string alert methods, so its easier to extend the co…
y0urself May 14, 2021
dcfd15b
We don't need to lower that, cause we upper it afterwards
y0urself May 14, 2021
d0b0860
Adjust alert method tippingpoint sms, to fit the Type
y0urself May 14, 2021
75b4904
Added CHANGELOG entry
y0urself May 14, 2021
d4eaae6
Merge branch 'master' of https://github.com/greenbone/python-gvm into…
y0urself May 14, 2021
c82dfe9
Resolve merge conflict
y0urself May 17, 2021
9761fe9
The else case cannot be accessed over the modify or create_alert comm…
y0urself May 17, 2021
2826ed4
Increase coverage of alerts
y0urself May 17, 2021
070d884
Test missing types correctly
y0urself May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Calendar Versioning](https://calver.org)html).
* Introduced new explicit API calls for SecInfo: `get_nvt()`, `get_nvt_list()`, `get_cpe()`, `get_cpe_list()`, `get_cve()`, `get_cve_list()`, `get_cert_bund_advisory()`, `get_cert_bund_advisory_list()`, `get_dnf_cert_advisory()`, `get_dnf_cert_advisory_list()`, `get_oval_definition()`, `get_oval_definition_list()`. [#456](https://github.com/greenbone/python-gvm/pull/456)

### Changed
* Detached the Alerts API calls from the GMP class into a new `AlertsMixin`. [#458](https://github.com/greenbone/python-gvm/pull/458)
* Detached the Notes and Overrides API calls from the GMP class into a new `NotesMixin` and `OverridesMixin`. [#457](https://github.com/greenbone/python-gvm/pull/457)
* Changed the API calls `get_nvt()` and `get_nvts()` to `get_scan_config_nvt()` and `get_scan_config_nvts()`. [#456](https://github.com/greenbone/python-gvm/pull/456)
* Detached the `InfoType` from the GMP types class. [#456](https://github.com/greenbone/python-gvm/pull/456)
Expand Down
10 changes: 10 additions & 0 deletions gvm/protocols/gmpv208/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,15 @@
from typing import Any, Callable, Optional

from gvm.protocols.gmpv208.gmpv208 import GmpV208Mixin
from gvm.protocols.gmpv208.entities.alerts import (
AlertCondition,
AlertEvent,
AlertMethod,
AlertsMixin,
get_alert_condition_from_string,
get_alert_event_from_string,
get_alert_method_from_string,
)
from gvm.protocols.gmpv208.entities.port_lists import (
get_port_range_type_from_string,
PortListMixin,
Expand Down Expand Up @@ -67,6 +76,7 @@

class Gmp(
GmpV208Mixin,
AlertsMixin,
NotesMixin,
OverridesMixin,
PortListMixin,
Expand Down
Loading