Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor python-gvm API] Step 2: Detach Alerts #458

Merged
merged 14 commits into from
May 17, 2021

Conversation

y0urself
Copy link
Member

What:

  • Detach Alerts and relevant Types

Why:

  • Improve python-gvm structure

How:

Split up the big Gmp class

Checklist:

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #458 (070d884) into master (da306ee) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   97.03%   97.17%   +0.14%     
==========================================
  Files          28       29       +1     
  Lines        3574     3545      -29     
==========================================
- Hits         3468     3445      -23     
+ Misses        106      100       -6     
Impacted Files Coverage Δ
gvm/protocols/gmpv208/entities/report_formats.py 100.00% <ø> (ø)
gvm/protocols/gmpv208/gmpv208.py 98.61% <ø> (+0.23%) ⬆️
gvm/protocols/gmpv208/types.py 97.91% <ø> (-0.46%) ⬇️
gvm/protocols/gmpv214/types.py 100.00% <ø> (ø)
gvm/protocols/gmpv208/entities/alerts.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da306ee...070d884. Read the comment docs.

@y0urself y0urself marked this pull request as ready for review May 17, 2021 09:04
@y0urself y0urself requested a review from a team as a code owner May 17, 2021 09:04
bjoernricks
bjoernricks previously approved these changes May 17, 2021
@bjoernricks bjoernricks enabled auto-merge May 17, 2021 09:08
@y0urself y0urself disabled auto-merge May 17, 2021 09:10
bjoernricks
bjoernricks previously approved these changes May 17, 2021
@y0urself y0urself merged commit c5fe8d9 into greenbone:master May 17, 2021
@y0urself y0urself deleted the detach-alerts branch October 9, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants