Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render volcanoes with a distinct icon from peaks #4331

Closed
wants to merge 6 commits into from

Conversation

ZeLonewolf
Copy link
Contributor

Fixes #1790

Changes proposed in this pull request:
Adds a new icon for volcanoes (natural=volcano), to make them distinct from the natural=peak icon.

Test rendering with links to the example place:
Location: https://www.openstreetmap.org/#map=13/19.3878/-155.2169

Before:
image

After:
image

@jeisenbe
Copy link
Collaborator

Thank you for working on this, @ZeLonewolf. I agree that this is an important change.

The initial rendering looks pretty good.

Since the tag natural=volcano is for a volcanic vent, which is not always at the top of a mountain but often in a low crater or fissure, could we try an icon that is slightly more crater-like and less peak-like?

I also think the “smoke” / ash cloud could be adjusted, though I can’t quite say how. Perhaps thinner, more like the whisp of smoke on the man_made=chimney icon?

@ZeLonewolf
Copy link
Contributor Author

Were you thinking something more like this?
image

I was actually thinking we wanted something closer in shape to a spatter cone or stratovolcano, vice a more geologically accurate pit crater, since it's a more stereotypically recognizable volcano shape. That's what I tried to make before I gave up and dropped in @imagico's icon, but I could be convinced either way.

@ZeLonewolf
Copy link
Contributor Author

Here's a version that simply combines the peak icon with the chimney icon's smoke trail:

image

Simple, but does the job. Though it doesn't achieve the "pit" you're looking for.

@ZeLonewolf
Copy link
Contributor Author

ZeLonewolf commented Feb 13, 2021

And lastly, here's a version with a more flat-ish top and the smoke wisp from man_made=chimney:

image

@imagico
Copy link
Collaborator

imagico commented Feb 13, 2021

Good idea to move forward with this.

When i implemented a similar change in the ac-style (99e5738) i chose to

  • eliminate the singular use color and chose to use the same color as for peaks and saddles (in particular important here where the red color clashes with the one used for healthcare).
  • start the volcano symbol two zoom levels later and use a smaller version for the first zoom level and this way avoid filling the map with lots of heavy icons at low zoom levels in some areas, in particular since we have no meaningful prioritization, areas to test for example:

https://www.openstreetmap.org/#map=12/28.9590/-13.6977
https://www.openstreetmap.org/#map=12/14.9304/-24.3809
https://www.openstreetmap.org/#map=11/-2.8371/35.9469
https://www.openstreetmap.org/#map=13/37.7480/15.0072

@ZeLonewolf
Copy link
Contributor Author

Here are some sample renderings at z10-13 using small icons at z10 and regular icons below that. I've also switched the volcanoes to use the same color as the regular peaks. I'm not really a fan of losing the red color as it's visually a lot more difficult to see the difference now.

Z10:
v_z10
Z11:
v_z11
Z13:
v_z13

What do people think of this approach?

@jeisenbe
Copy link
Collaborator

  1. I agree with changing the color to match peaks and saddles. It does not make semantic sense that these would use the same color as healthcare features.

  2. The smaller icon is a clever idea, but it would need to be implemented with smaller icons for peaks at those zoom levels as well, as in 99e5738 - else the peaks will look too heavy in contrast, I think.

  3. I like what you tried in Render volcanoes with a distinct icon from peaks #4331 (comment) - but could we perhaps try that crater shape plus the original ash cloud?

Volcano and peak will now show at 50% width at zoom 10.  Combined peak/volcano section to take advantage of common styling.
@ZeLonewolf
Copy link
Contributor Author

I've updated the PR to use the flat-ish top with the original wisp. I think it looks pretty good like this. Also, peaks and volcanoes now use the same style and zoom sections, as I brought them into a common stylesheet block.

z10:
image
z11:
image
z12:
image
z13:
image

@imagico
Copy link
Collaborator

imagico commented Feb 27, 2021

Like in case of #4317 (comment) also here a few cartographic design principles we tend to follow here this change has issues with:

  • We try to avoid combining several unrelated changes into one - in this case you extend rendering of peaks to z10 which has nothing to do with the change of the symbol for volcanoes (and would be a questionable change on its own as well - see areas like here or here).
  • When changing symbol sizes, line widths etc. from one zoom level to the other it is advisable to enlage them by less than a factor of two. This way you avoid the symbol geometries aligning to ground features across several zoom levels and therefore map users potentially mistaking symbols for real world geometries or getting the impression that they are zooming into a static image rather than a dynamic map.
  • Symbols should always be readable for what they are meant to depict. If a symbol is too small for that you either have to produce a simplified version that meets this requirement or you cannot show the symbol in that form. As a general rule we typically design all symbols specifically for the target scale and don't reuse the same symbol in different sizes.
  • When there is no meaningful prioritization (and in case of volcanoes the ele tag is not a meaningful criterion) the starting zoom level should be chosen so that the majority of features are shown at the starting zoom level already and no significant arbitrary selection takes place.

To me your tests seem to confirm that the approach taken (a pictorial point symbol to visualize volcanoes) does only work well in this style when you start the symbol significantly later than the abstract symbol for peaks - probably no earlier than z13. But i would be happy to be proven wrong about this.

Also keep in mind that the whole point of the exercise is to solve #1790 and not render volcanoes any more in a way that implies they are a subtype of peaks. I am not sure if your current proposal really accomplishes that. It removes the additional color used for volcanoes (which is a good thing) but otherwise by rendering a symbol which clearly looks like a derivative of the peak symbol in exactly the same fashion to me still communicates this being a subtype of the same feature class.

@ZeLonewolf
Copy link
Contributor Author

What I think I'm hearing is that we want to:

  • Start the rendering of peaks/volcanoes at zoom 10, with the triangle peak symbol
  • At zoom 13, begin showing a difference in icon between peak and volcano. This matches the same zoom level that you start to see crater rims, so that's visually consistent.

Would that be satisfactory?

@imagico
Copy link
Collaborator

imagico commented Feb 27, 2021

I don't think that would be a good idea. As written in #1790 what is non-satisfying right now is that we render natural=volcano in a way that implies it is a type of peak. It would be good to change that in a way that would communicate to the map user that it is not and at the same time it would be good to avoid using a color for the symbol that is very similar to the healthcare color. If you'd render peaks and volcanoes identically at lower zoom levels that would communicate the opposite and reinforce the current conflation so i don't think that would be desirable.

My idea - which i showed in 99e5738 - was to show only peaks with the abstract triangle symbol starting at z11 and show volcanoes with a normal pictorial symbols starting later (at z13). I encourage you to explore other options though and hope that the design principles i sketched might help a bit with that.

@ZeLonewolf
Copy link
Contributor Author

Can you clarify what you mean by the "abstract triangle symbol"? Since it's in vector form, why would you need a separate image for the small version vice just shrinking it in CSS?

@imagico
Copy link
Collaborator

imagico commented Feb 27, 2021

The peak symbol is a simple triangle and is recognizable as such quite easily. The volcano symbol OTOH is a pictorial symbol, it requires recognition of the specific and more complex shape and its meaning to be readable.

You don't absolutely need a separate symbol design for different scales in all cases but usually, especially if as recommended the scale difference is something other than a power of two, the best readability calls for varying the symbol depending on the scale it is to be rendered at. When the symbol is rendered larger, details help recognition of the shape for what it is meant to depict while if it is shown smaller that additional detail will lead to blurriness and more difficult readability.

@ZeLonewolf
Copy link
Contributor Author

Okay, (try again) so what I think I'm hearing is:

  1. Render peaks as they are currently (zoom 11+)
  2. Render volcanoes from zoom 13+
  3. Volcano icons don't look like peaks

Perhaps the volcano icon could follow a concept of "smoke rising from the ground"?

@ZeLonewolf
Copy link
Contributor Author

Here is a concept I've been playing with, to go for more of a "pit" style icon. Thoughts?
z12
z13

@HolgerJeromin
Copy link
Contributor

Here is a concept I've been playing with, to go for [...] icon. Thoughts?

I like the many birds in this rendering :-)

@ZeLonewolf
Copy link
Contributor Author

Well. I can't unsee that now. Back to the drawing board.

@jeisenbe
Copy link
Collaborator

I think this looked good at z13 and higher zoom levels:

It was just the z11 / z12 that was a problem.

@ZeLonewolf
Copy link
Contributor Author

Unless I'm misreading @imagico's comments above, it sounded like there was an objection to iconography that indicated that volcanoes were a subtype of peak.

@jeisenbe
Copy link
Collaborator

I believe that comment was in response to your plan to "Start the rendering of peaks/volcanoes at zoom 10, with the triangle peak symbol”, not in response to the new volcano icon.

@imagico
Copy link
Collaborator

imagico commented Feb 28, 2021

The peak symbol is eight pixels in size so working out something suitable in the standard 14 pixel symbol size should typically allow an impression sufficiently different from the peak symbol to make clear it is a fundamentally different type of feature.

I don't think the pit style design you showed is intuitively readable but that is in principle the kind of experiment i wanted to encourage. The question is ultimately what does most clearly say 'volcano' that can work in a 14 pixel symbol. The cratered mountain with cloud design you showed earlier in principle seems to work though it could probably be a bit more distinct from peaks in the base shape and it also appears to be a bit blurry as is. See the ac-style version for comparison here:

http://www.imagico.de/map/pict/ac_samples/tenerife_z16.png

@ZeLonewolf
Copy link
Contributor Author

ZeLonewolf commented Feb 28, 2021

Ah, I was working off the volcano icon file to start from so it sounds like I'm using the wrong size. 14 pixels is considerably more breathing room. Is there a style guide somewhere that I should be looking at?

@ZeLonewolf
Copy link
Contributor Author

Latest experiment -- "smoke rising from crater", now in 14 pixel version.

image

@ZeLonewolf
Copy link
Contributor Author

Below rendering is with a 14px version of the volcano with smoke icon. This seems to be the preference. I have the volcanoes starting to render at zoom=13.

z12
download (1)

z13
download (2)

z14
download (3)

Also, if anyone has any tips for the best way to generate these screen shots, I'd appreciated it. Are you using the export function in kosmtik or just taking screen shots?

@imagico
Copy link
Collaborator

imagico commented Mar 3, 2021

I think i am probably not the best person to make a neutral assessment here having worked on the very same problem before and in doing that having already formed an opinion on the matter.

So i would encourage others to chime in here with comments on the specifics of the symbol design.

Regarding sample rendering productions - the most common method is screenshots, the export function makes it too easy to produce wrong scale rendering in my experience.

@Nic787
Copy link

Nic787 commented Mar 28, 2021

Hi,

jumping in here, because of the recent eruption in Iceland. I prefer having the red color personally, because it would help users differentiate normal peak and dangerous area (volcano). I love your flat peak with a bit of smoke.

@imagico
Copy link
Collaborator

imagico commented Jul 17, 2021

As said above in #4331 (comment) someone else should review this (both maintainer and non-maintainer reviews welcome) since i am a bit biased here having addressed this problem in a different fashion elsewhere.

symbols/natural/volcano.svg Outdated Show resolved Hide resolved
style/amenity-points.mss Show resolved Hide resolved
@ZeLonewolf ZeLonewolf marked this pull request as draft September 9, 2021 20:27
@ZeLonewolf
Copy link
Contributor Author

Updated with changes requested. However, due to the issues noted at #4381 (comment), I am not able to run this PR. I temporarily removed the golf code in order to generate these render samples.

Test renders, zoom 10-13:
image
image
image
image

@ZeLonewolf ZeLonewolf marked this pull request as ready for review September 12, 2021 01:49
@pnorman pnorman self-requested a review September 16, 2021 03:46
@ZeLonewolf
Copy link
Contributor Author

Closing so other contributors can work on this.

@ZeLonewolf ZeLonewolf closed this Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

render natural=volcano different from natural=peak
7 participants