-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change icon for shelter_type=public_transport #4317
Change icon for shelter_type=public_transport #4317
Conversation
The default shelter icon looks a bit strange for shelters tagged with `shelter_type=public_transport`; the minimal shelter type you would find at a bus or tram stop. This commit introduces a distinct icon for this shelter type, and changes the colour of it to `@transportation-icon` to match the public transport stop itself.
This suggestion clashes with a number of important principles of map design we tend to follow in OSM-Carto:
It would be perfectly fine to use a variation of the shelter symbol to indicate a public transport shelter is tagged specifically as such with the variation not being that intuitive as long as the base symbol is still recognizable as the general shelter symbol and the variation is not directly misleading. |
@jdhoek would you be interested in either modifying the main |
Public transport shelters all share the characteristic that there is no guarantee that they are suitable for more than a modicum of shelter while waiting for a bus or tram. Most are open to at least one side and are size constrained, and the icon should indicate that the goal of this type of shelter is quite different from a generic In many, if not most countries such shelters are variations on a roof on stilts without walls or a roof with some minimal walls on at most three sides. Representing it as a little house that will definitely keep you dry in stormy weather is misleading. I don't think anything I can suggest will address the list of negative points raised by @imagico. In fact, if I apply those conditions to almost any of the existing icons, they all fail. It effectively discourages the contribution of any new icons. I mean, the current shelter icon fails on points 2, 3, and 4 too. |
Well is is meant to protect against the occasional rain shower and a bit from the wind. What else than a minimalist roof and some wall would be suitable for that? Closed buildings maybe, but they would probably be mapped as a bus station. I respect @imagico's perfectionism, but lacking a perfect solution a pragmatic one will help as well. The icon is in transport-blue, and typically found in proximity to the bus stop. Thus some clues for the map user to relate it correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs revisiting the symbol design - it would need to be something that is universally recognizable as a subtype of shelter. More guidance can be found in the comments above.
With the requested changes in #4317 (comment) and #4317 (review) unaddressed, I'm going to go ahead and close this as abandoned. |
The default shelter icon looks a bit strange for shelters tagged with
shelter_type=public_transport
; the minimal shelter type you would find at a bus or tram stop.This commit introduces a distinct icon for this shelter type, and changes the colour of it to
@transportation-icon
to match the public transport stop itself.This type of icon was suggested by @polarbearing in #4270.
Rendering
Seems to work okay with shelters mapped as buildings too:
At the very least no worse than the generic shelter icon.
Current icon and colour